Add cmake-lint command to dev shell
Depends on D4294
Differential D4564 Authored by • jon on Jul 18 2022, 2:52 PM.
Tags None Referenced Files
Details
Summary Add cmake-lint command to dev shell Depends on D4294 Test Plan nix develop cmake-lint --help
Diff Detail
Event TimelineHerald added subscribers: • abosh, • adrian, tomek. · View Herald TranscriptJul 18 2022, 2:52 PM2022-07-18 14:52:42 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 18 2022, 2:56 PM2022-07-18 14:56:57 (UTC-7) Harbormaster completed remote builds in B10598: Diff 14591.Jul 18 2022, 3:38 PM2022-07-18 15:38:26 (UTC-7) • jon added a parent revision: D4565: [Chore] Lint services/backup/CMakeLists.txt.Jul 18 2022, 3:40 PM2022-07-18 15:40:14 (UTC-7) Harbormaster completed remote builds in B10600: Diff 14593.Jul 18 2022, 3:48 PM2022-07-18 15:48:57 (UTC-7) Comment Actions Looks good to me, accepting and adding @ashoat as blocking reviewer since this introduces a new dependency. (In the future it'd probably be helpful to link to something that shows what cmake-format corresponds to eg https://github.com/NixOS/nixpkgs/blob/nixos-22.05/pkgs/development/tools/cmake-format/default.nix or a GitHub repo or something) This revision is now accepted and ready to land.Jul 18 2022, 5:58 PM2022-07-18 17:58:57 (UTC-7) This revision now requires review to proceed.Jul 18 2022, 5:59 PM2022-07-18 17:59:04 (UTC-7) Comment Actions
Do you mean like which upstream it uses? (e.g. https://github.com/cheshirekow/cmake_format) Comment Actions Wondering where the config for cmake-format goes, and if there's a way to configure the max line length This revision is now accepted and ready to land.Jul 19 2022, 8:22 AM2022-07-19 08:22:19 (UTC-7) Comment Actions
Default is 80 Comment Actions @atul not sure what format you wanted the info, but with nix you can also just query the underlying package: $ nix eval nixpkgs#cmake-format.meta.homepage "https://github.com/cheshirekow/cmake_format" Comment Actions
Oh sweet TIL, I'll jot that down Closed by commit rCOMM57090061bb3d: [Nix] Add cmake-format to dev shell (authored by • jon). · Explain WhyJul 20 2022, 12:00 PM2022-07-20 12:00:10 (UTC-7) This revision was automatically updated to reflect the committed changes. • jon removed a parent revision: D4294: [nix] Add dependencies needed to compile native modules.Jul 27 2022, 12:25 PM2022-07-27 12:25:38 (UTC-7)
Revision Contents
Diff 14593 nix/dev-shell.nix
|