Paths

Table of Contentst

Differential D4884

[services] Backup - Rust lib - Add is initialized
ClosedPublic
Actions

Authored by • karol on Aug 19 2022, 1:28 AM.

Tags

None

Referenced Files

	F3536194: D4884.id16064.diff
	Wed, Dec 25, 5:43 PM

	F3536187: D4884.id15994.diff
	Wed, Dec 25, 5:41 PM

	Unknown Object (File)
	Sun, Dec 15, 10:32 PM

	Unknown Object (File)
	Sat, Dec 14, 7:02 AM

	Unknown Object (File)
	Sat, Dec 14, 7:02 AM

	Unknown Object (File)
	Sat, Dec 14, 7:02 AM

	Unknown Object (File)
	Sat, Dec 14, 7:02 AM

	Unknown Object (File)
	Sat, Dec 14, 7:02 AM

Subscribers

Details

Reviewers

varun
tomek
ashoat
• jon

Commits

rCOMM15ddad8a5688: [services] Backup - Rust lib - Add is initialized

Summary

Depends on D4861

Adding a function that checks whether the client's been initialized

Test Plan

test plan in D4870

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Aug 19 2022, 1:28 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptAug 19 2022, 1:28 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 19 2022, 1:29 AM

Harbormaster failed remote builds in B11468: Diff 15779!

• karol edited the summary of this revision. (Show Details)Aug 19 2022, 1:32 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: varun, tomek.

• karol added a parent revision: D4861: [services] Backup - Add Rust.

• karol added a child revision: D4867: [services] Backup - Rust lib - Add initialize.

• karol requested review of this revision.Aug 19 2022, 1:43 AM

Adding @ashoat because there are new dependencies.

services/backup/rust_lib/Cargo.toml
8	Why do we use `1.0` when `1.20` is available? I think in some diff it was agreed that we should specify major and minor versions.
9–11	In one diff it was agreed that we should specify major and minor versions. @varun am I right?
services/backup/rust_lib/src/lib.rs
16	We should avoid using legacy syntax and instead use `use`.

Dependencies seem reasonable, but curious about @tomek's versioning questions above

varun accepted this revision.Aug 22 2022, 8:55 AM

varun added inline comments.

services/backup/rust_lib/Cargo.toml
9–11	yeah we should omit the patch version
services/backup/rust_lib/src/lib.rs
33–38	can just combine these with an "or" operator, right?

This revision is now accepted and ready to land.Aug 22 2022, 8:55 AM

ci

Harbormaster completed remote builds in B11584: Diff 15926.Aug 24 2022, 6:50 AM

• karol added inline comments.Aug 25 2022, 3:29 AM

services/backup/rust_lib/Cargo.toml
8	ok, we can change to `1.20`
9–11	ok
services/backup/rust_lib/src/lib.rs
16	ok
33–38	We can do this super simple thing in many more ways, I don't think that matters, really.

address comments

Harbormaster completed remote builds in B11607: Diff 15965.Aug 25 2022, 3:42 AM

run cargo fmt

Harbormaster completed remote builds in B11615: Diff 15978.Aug 25 2022, 5:22 AM

Something (probably rebase) went wrong with this diff. An update with run cargo fmt description introduced a lot of new code.

This revision now requires changes to proceed.Aug 25 2022, 9:58 AM

update

Harbormaster completed remote builds in B11628: Diff 15994.Aug 26 2022, 1:39 AM

tomek accepted this revision.Aug 26 2022, 1:50 AM

This revision is now accepted and ready to land.Aug 26 2022, 1:50 AM

Closed by commit rCOMM15ddad8a5688: [services] Backup - Rust lib - Add is initialized (authored by • karol). · Explain WhyAug 29 2022, 7:02 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM15ddad8a5688: [services] Backup - Rust lib - Add is initialized.

Herald added a reviewer: • jon. · View Herald TranscriptAug 29 2022, 7:02 AM

Revision Contents
Changeset List

Path

Size

1 line

services/

backup/

rust_lib/

4 lines

src/

1 line

48 lines

Diff 15779

.gitignore

Loading...

services/backup/rust_lib/Cargo.lock

Loading...

services/backup/rust_lib/Cargo.toml

Loading...

services/backup/rust_lib/src/constants.rs

Loading...

services/backup/rust_lib/src/lib.rs

Loading...