Paths

Table of Contentst

-
native/cpp/CommonCpp/grpc/grpc_client/
-
cpp/
-
CommonCpp/
-
grpc/
-
grpc_client/
-
build.rs

[native] add c++11 flag to build
ClosedPublic
Actions

Authored by varun on Aug 25 2022, 4:03 AM.

Details

Reviewers

tomek
• karol
atul

Commits

rCOMMe06b3c38cc10: [native] add c++11 flag to build

Summary

this ensures that the compiler knows which edition of C++ to use.

Test Plan

cargo build

Diff Detail

Repository

rCOMM Comm

Branch

identity-client (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 25 2022, 4:03 AM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptAug 25 2022, 4:03 AM

Only add flag if it exists

varun added a child revision: D4951: [native] remove unused types.Aug 25 2022, 4:06 AM

Harbormaster completed remote builds in B11608: Diff 15971.Aug 25 2022, 4:13 AM

Harbormaster completed remote builds in B11609: Diff 15972.

varun requested review of this revision.Aug 25 2022, 4:14 AM

varun added 1 blocking reviewer(s): atul.Aug 25 2022, 10:31 AM

Looks reasonable based on the example here: https://docs.rs/cxx-build/latest/cxx_build/#example. Guessing we're going with C++ 11 here because it's the lowest common denominator across native?

In D4950#143596, @atul wrote:

Looks reasonable based on the example here: https://docs.rs/cxx-build/latest/cxx_build/#example. Guessing we're going with C++ 11 here because it's the lowest common denominator across native?

yeah that's right. hopefully we can bump native to C++20 and then upgrade this as well

varun removed 1 blocking reviewer(s): tomek.Aug 25 2022, 11:13 AM

This revision is now accepted and ready to land.Aug 25 2022, 11:13 AM

hopefully we can bump native to C++20 and then upgrade this as well

I think realistically C++ 14, but yeah anything >= 11 should be good

Closed by commit rCOMMe06b3c38cc10: [native] add c++11 flag to build (authored by varun). · Explain WhyAug 25 2022, 11:34 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMe06b3c38cc10: [native] add c++11 flag to build.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

grpc_client/

build.rs

3 lines

Diff 15972

View Options

native/cpp/CommonCpp/grpc/grpc_client/build.rs

	Show All 11 Lines
	#include <string>			#include <string>

	namespace comm {			namespace comm {
	namespace network {			namespace network {

	class ServiceBlobClient {			class ServiceBlobClient {
	std::unique_ptr<blob::BlobService::Stub> stub;			std::unique_ptr<blob::BlobService::Stub> stub;

				public:
	ServiceBlobClient() {			ServiceBlobClient() {
	// TODO: handle other types of connection			// todo handle different types of connection(e.g. load balancer)
	std::string targetStr = "blob-server:50051";			std::string targetStr = "blob-server:50051";
	std::shared_ptr<grpc::Channel> channel =			std::shared_ptr<grpc::Channel> channel =
	grpc::CreateChannel(targetStr, grpc::InsecureChannelCredentials());			grpc::CreateChannel(targetStr, grpc::InsecureChannelCredentials());
	this->stub = blob::BlobService::NewStub(channel);			this->stub = blob::BlobService::NewStub(channel);
	}			}

	public:			void put(std::shared_ptr<reactor::BlobPutClientReactor> putReactor) {
	static ServiceBlobClient &getInstance() {			if (putReactor == nullptr) {
	// todo consider threads
	static ServiceBlobClient instance;
	return instance;
	}

	std::unique_ptr<reactor::BlobPutClientReactor> putReactor;

	void put(const std::string &holder, const std::string &hash) {
	if (this->putReactor != nullptr && !this->putReactor->isDone()) {
	throw std::runtime_error(			throw std::runtime_error(
	"trying to run reactor while the previous one is not finished yet");			"put reactor is being used but has not been initialized");
	}			}
	this->putReactor.reset(new reactor::BlobPutClientReactor(holder, hash));			this->stub->async()->Put(&putReactor->context, &(*putReactor));
	this->stub->async()->Put(&this->putReactor->context, &(*this->putReactor));			putReactor->nextWrite();
	this->putReactor->nextWrite();
	}			}
	// void get(const std::string &holder);			// void get(const std::string &holder);
	// void remove(const std::string &holder);			// void remove(const std::string &holder);
	};			};

	} // namespace network			} // namespace network
	} // namespace comm			} // namespace comm

[native] add c++11 flag to buildClosedPublicActions