Looks reasonable based on the example here: https://docs.rs/cxx-build/latest/cxx_build/#example. Guessing we're going with C++ 11 here because it's the lowest common denominator across native?

In D4950#143596, @atul wrote:

Looks reasonable based on the example here: https://docs.rs/cxx-build/latest/cxx_build/#example. Guessing we're going with C++ 11 here because it's the lowest common denominator across native?

yeah that's right. hopefully we can bump native to C++20 and then upgrade this as well

varun removed 1 blocking reviewer(s): tomek.Aug 25 2022, 11:13 AM

This revision is now accepted and ready to land.Aug 25 2022, 11:13 AM

hopefully we can bump native to C++20 and then upgrade this as well

I think realistically C++ 14, but yeah anything >= 11 should be good

Closed by commit rCOMMe06b3c38cc10: [native] add c++11 flag to build (authored by varun). · Explain WhyAug 25 2022, 11:34 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMe06b3c38cc10: [native] add c++11 flag to build.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

grpc_client/

build.rs

3 lines

Diff 15991

View Options

native/cpp/CommonCpp/grpc/grpc_client/build.rs

[native] add c++11 flag to buildClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 15991

native/cpp/CommonCpp/grpc/grpc_client/build.rs

[native] add c++11 flag to build
ClosedPublic
Actions

Revision Contents
Changeset List