Page MenuHomePhabricator
Differential D5045

[Native] Prune protobuf logic from CMakeLists.txt
ClosedPublic
Actions

Authored by • jon on Sep 2 2022, 5:34 PM.
Tags
None
Referenced Files
F3368581: D5045.id16513.diff
Mon, Nov 25, 8:18 PM
F3368376: D5045.id16425.diff
Mon, Nov 25, 7:34 PM
Unknown Object (File)
Oct 26 2024, 2:15 AM
Unknown Object (File)
Oct 26 2024, 2:15 AM
Unknown Object (File)
Oct 26 2024, 2:15 AM
Unknown Object (File)
Oct 26 2024, 2:11 AM
Unknown Object (File)
Sep 28 2024, 8:05 AM
Unknown Object (File)
Sep 27 2024, 2:09 AM
View All 99 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
• max
• karol
• abosh
Commits
rCOMM8c10fa75ce71: [Native] Prune protobuf logic from CMakeLists.txt
Summary

Remove the protobuf projects from
native/cpp/CommonCpp/grpc/CMakeLists.txt

Only the grpc client remains

https://linear.app/comm/issue/ENG-1231

Test Plan

CI gates pass

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Sep 2 2022, 5:34 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 2 2022, 5:34 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 2 2022, 5:37 PM
Harbormaster failed remote builds in B11862: Diff 16275!
• jon added a child revision: D5046: [Native] Remove old protos and related files.Sep 2 2022, 5:41 PM
• jon updated this revision to Diff 16279.Sep 2 2022, 6:20 PM

Rebase with backup fixes

Harbormaster completed remote builds in B11866: Diff 16279.Sep 2 2022, 6:29 PM
• jon requested review of this revision.Sep 2 2022, 6:29 PM
• jon edited the summary of this revision. (Show Details)Sep 6 2022, 7:33 AM
• jon added a parent revision: D4992: [Shared] Copy protos to shared/protos, adjust CMake.Sep 6 2022, 9:14 AM
atul accepted this revision.Sep 7 2022, 8:32 AM
This revision is now accepted and ready to land.Sep 7 2022, 8:32 AM
• jon updated this revision to Diff 16425.Sep 7 2022, 9:46 AM

Rebase on master

Harbormaster failed remote builds in B11971: Diff 16425!Sep 7 2022, 9:49 AM
Harbormaster completed remote builds in B11971: Diff 16425.Sep 7 2022, 11:23 AM
• jon mentioned this in D5084: [native] add CXX header files to Xcode project.Sep 8 2022, 10:22 AM
Closed by commit rCOMM8c10fa75ce71: [Native] Prune protobuf logic from CMakeLists.txt (authored by • jon). · Explain WhySep 8 2022, 10:30 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM8c10fa75ce71: [Native] Prune protobuf logic from CMakeLists.txt.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
grpc/
84 lines
4 lines
4 lines

Diff 16275

View Options

native/cpp/CommonCpp/grpc/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/grpc/Client.h

Loading...
View Options

native/cpp/CommonCpp/grpc/ClientGetReadReactor.h

Loading...