Details
Please view the attached screenshots to see the before and after of the changes I made:
Before:
6 threads would cause the picker to paginate and show the first 5 threds
After:
Now all 6 threads are shown
Diff Detail
- Repository
- rCOMM Comm
- Branch
- eng-1778
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
At a high level this looks good, but let's go through this component one more time and double check that everything related to pagination has been removed.
| web/calendar/thread-picker.react.js | ||
|---|---|---|
| 43 ↗ | (On Diff #17089) | Is there a reason we need to keep this type around given the contents are empty? |
| 46 ↗ | (On Diff #17089) | Is pageSize still being used anywhere? |
Looks good to me, I took a look at the new revision based off of the previous comments and pulled the diff down locally to test it. Works as expected on my local environment
Looks super close, let's remove LeftPager and RightPager in this diff as well.. couldn't find any other usage in the codebase.
| web/calendar/thread-picker.react.js | ||
|---|---|---|
| 11 ↗ | (On Diff #17111) | Are LeftPager or RightPager used elsewhere in the codebase? If not, let's remove those as well in this diff |