Page MenuHomePhabricator
Differential D5333

[landing] made investor profile cards mobile friendly
ClosedPublic
Actions

Authored by ginsu on Oct 10 2022, 8:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 12, 12:06 AM
Unknown Object (File)
Tue, Jun 11, 10:43 AM
Unknown Object (File)
Mon, Jun 10, 3:57 AM
Unknown Object (File)
Tue, Jun 4, 8:46 PM
Unknown Object (File)
Tue, Jun 4, 3:04 AM
Unknown Object (File)
Sat, May 18, 8:35 AM
Unknown Object (File)
Sat, May 18, 8:35 AM
Unknown Object (File)
Sat, May 18, 8:34 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
atul
• abosh
rohan
ashoat
Commits
rCOMMf192318a1b89: [landing] made investor profile cards mobile friendly
Summary

Will not land until all diffs in the stack are accepted

Investor cards are now mobile friendly with the profile pictures going above the text whenever the screen width is less than 600px

Next diffs:

  1. Create Modal component for investor profile cards
  2. Populate investor cards with data

Linear Task: ENG-1953
Figma: Investor Page

Depends on D5328

Test Plan

Please see attached video and screenshots to see how investor profile cards look/act:

iPhone 12 View:

Screen Shot 2022-10-10 at 9.42.01 AM.png (1×3 px, 1 MB)

Responsive Window View:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 10 2022, 8:10 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 10 2022, 8:10 AM
ginsu edited the summary of this revision. (Show Details)Oct 10 2022, 8:13 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat, • abosh, rohan.
ginsu added a parent revision: D5328: [landing] implemented investor profile card component boilerplate.
ginsu attached a referenced file: F194905: Screen Recording 2022-10-10 at 9.42.11 AM.mov. (Show Details)
ginsu attached a referenced file: F194904: Screen Shot 2022-10-10 at 9.42.01 AM.png. (Show Details)
Harbormaster completed remote builds in B12702: Diff 17454.Oct 10 2022, 8:21 AM
ginsu requested review of this revision.Oct 10 2022, 8:21 AM
ashoat resigned from this revision.Oct 10 2022, 8:58 AM

Looks good, defer to @atul

atul accepted this revision.Oct 10 2022, 11:07 AM
atul added inline comments.
landing/investor-profile.css
54–55 ↗(On Diff #17454)

We can use margin shorthand here

This revision is now accepted and ready to land.Oct 10 2022, 11:07 AM
atul added inline comments.Oct 10 2022, 11:09 AM
landing/investor-profile.css
54–55 ↗(On Diff #17454)
margin: 16px 0 0;
ginsu updated this revision to Diff 17456.Oct 10 2022, 11:50 AM

fixed margin shorthand

Harbormaster completed remote builds in B12704: Diff 17456.Oct 10 2022, 11:59 AM
atul accepted this revision.Oct 10 2022, 12:04 PM
rohan accepted this revision.Oct 10 2022, 12:23 PM

Responsiveness looks good!

ginsu updated this revision to Diff 17657.Oct 19 2022, 9:12 AM

rebase

Harbormaster completed remote builds in B12866: Diff 17657.Oct 19 2022, 9:23 AM
ginsu added a child revision: D5389: [landing] implemented investor profile modal UI design.Oct 19 2022, 11:02 AM
Closed by commit rCOMMf192318a1b89: [landing] made investor profile cards mobile friendly (authored by ginsu). · Explain WhyOct 21 2022, 4:58 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMf192318a1b89: [landing] made investor profile cards mobile friendly.

Revision Contents
Changeset List

PathSize
landing/
11 lines

Diff 17657

View Options

landing/investor-profile.css

Loading...