Details

Reviewers

• jon
varun
marcin
tomek

Commits

rCOMMe8d2e66a98bc: [services] Tunnelbroker - Initialization function exposed to Rust

Summary

This diff is a part of the flat diffs stack to transform the current Tunnelbroker project into a Rust app by calling the current C++ codebase from Rust. The related transition task is ENG-1072.

This diff introduces creating a Tunnelbroker.h header file which will be exposed and run in Rust main application entry point at main.rs (D5432) which contains an initialization function that calls the initialization functions from the former server.cpp.

Related Linear task: ENG-2092

CI Notice:
The CI will fail on this and further diffs until the D5461 where the changes to CI build commands are made.
This stack will be landed all in one to prevent CI from failing on diffs out of this stack.

Test Plan

1. CI Testing:
These diff changes are included as a part of the stack in the later D5461 diff, where the changes to CI build commands are made. The CI succeded on the D5461 which reflects that this changes are passing the build.

2. Manually testing:
These diff changes can be tested in the middle of the stack at D5436. To test it patch to D5436 using arc patch D5436, run nix develop. Go to tunnelbroker service directory services/tunnelbroker and run the Cargo building process cargo build or cargo run.
The Rust application will be successfully built.

Diff Detail

Repository

rCOMM Comm

Branch

creating-header

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Oct 20 2022, 7:34 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 20 2022, 7:34 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure.Oct 20 2022, 7:35 AM

• max added a child revision: D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.

Harbormaster failed remote builds in B12921: Diff 17712!Oct 20 2022, 7:36 AM

• max edited the summary of this revision. (Show Details)Oct 20 2022, 8:00 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, marcin. • max added 1 blocking reviewer(s): • jon.

• max mentioned this in D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust.Oct 20 2022, 8:09 AM

• max published this revision for review.Oct 20 2022, 8:22 AM

• max added a child revision: D5431: [services] Tunnelbroker - Removing of deprecated C++ files.Oct 24 2022, 3:05 AM

• max removed a child revision: D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.

• max edited the summary of this revision. (Show Details)Oct 24 2022, 9:21 AM

• max edited the test plan for this revision. (Show Details)

• jon accepted this revision.Oct 25 2022, 5:39 PM

This revision is now accepted and ready to land.Oct 25 2022, 5:39 PM

• max added a reviewer: tomek.Oct 26 2022, 2:23 AM

This revision now requires review to proceed.Oct 26 2022, 2:23 AM

tomek accepted this revision.Oct 27 2022, 4:15 AM

tomek added inline comments.

services/tunnelbroker/src/libcpp/Tunnelbroker.cpp
17–34 ↗	(On Diff #17712)	Were we checking this in the original version? I think this check is beneficial, but we still need to check if a table exists when performing operations later.

This revision is now accepted and ready to land.Oct 27 2022, 4:15 AM

• max marked an inline comment as done.Nov 7 2022, 4:33 AM

• max added inline comments.

services/tunnelbroker/src/libcpp/Tunnelbroker.cpp
17–34 ↗	(On Diff #17712)	Were we checking this in the original version? I think this check is beneficial, but we still need to check if a table exists when performing operations later. We were checking it when the gRPC handler was constructed. It doesn't make sense to me to check the table on every operations because the operation will fail anyway if table doesn't exists. We are checking tables at the start because database operation can be invoked later, but we want to know are the table exists at the start of the app to fail if they are not.