Paths

Table of Contentst

Differential D5360

[services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`
ClosedPublic
Actions

Authored by • max on Oct 13 2022, 7:22 AM.

Tags

None

Referenced Files

	F2905355: D5360.id18130.diff
	Sun, Oct 6, 4:50 AM

	F2905337: D5360.id17542.diff
	Sun, Oct 6, 4:42 AM

	F2905223: D5360.id17876.diff
	Sun, Oct 6, 4:01 AM

	F2905204: D5360.id17617.diff
	Sun, Oct 6, 3:56 AM

	F2905194: D5360.id18129.diff
	Sun, Oct 6, 3:52 AM

	F2905189: D5360.id17873.diff
	Sun, Oct 6, 3:51 AM

	Unknown Object (File)
	Fri, Sep 27, 7:42 AM

	Unknown Object (File)
	Thu, Sep 26, 9:38 PM

Subscribers

Details

Reviewers

• jon
marcin
michal
varun
tomek

Commits

rCOMM38f3bc4c4abe: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`

Summary

This diff introduces adding the protobuf file compilation to Cargo's build system.
This is an intentional requirement to use Tonic.

Related Linear task: ENG-2094

CI Notes:
CI will fail until the D5461 will be landed.
This diff will re-request CI building before landing it.

Test Plan

Service and Rust-part of the codebase successfully built by running of cargo build command in the services/tunnelbroker directory.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Oct 13 2022, 7:22 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 13 2022, 7:22 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

Harbormaster failed remote builds in B12772: Diff 17542!Oct 13 2022, 7:27 AM

• max edited the summary of this revision. (Show Details)Oct 13 2022, 7:29 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: marcin, michal.

• max added a parent revision: D5380: [services] Tunnelbroker - Unifying paths in Docker according to the local repository.Oct 17 2022, 8:06 AM

Rebased on the parent changes.

Harbormaster completed remote builds in B12832: Diff 17617.Oct 17 2022, 8:19 AM

• max published this revision for review.Oct 17 2022, 8:24 AM

ashoat added a reviewer: varun.Oct 17 2022, 9:48 AM

varun accepted this revision.Oct 17 2022, 10:18 AM

varun added inline comments.

services/tunnelbroker/rust-lib/build.rs
6 ↗	(On Diff #17617)	why not just make the const on line 1 the path to the file instead of the directory?

This revision is now accepted and ready to land.Oct 17 2022, 10:18 AM

• max marked an inline comment as done.Oct 20 2022, 1:48 AM

• max added inline comments.

services/tunnelbroker/rust-lib/build.rs
6 ↗	(On Diff #17617)	why not just make the const on line 1 the path to the file instead of the directory? Yes, we can do this. The current approach comes from the other services (backup, blob), but it makes sense to use a file as we are using a single protobuf.

• max added a reviewer: tomek.Oct 20 2022, 1:48 AM

This revision now requires review to proceed.Oct 20 2022, 1:48 AM

Adding @tomek as a final reviewer.

tomek accepted this revision.Oct 20 2022, 7:00 AM

This revision is now accepted and ready to land.Oct 20 2022, 7:00 AM

Adding to the Tunnelbroker to Rust transition stack.
Rebased on the Cargo stack changes.

• max edited the summary of this revision. (Show Details)Oct 24 2022, 10:14 AM

• max added a parent revision: D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo`.

• max removed a parent revision: D5380: [services] Tunnelbroker - Unifying paths in Docker according to the local repository.

• max edited the summary of this revision. (Show Details)Oct 24 2022, 10:17 AM

• max edited the test plan for this revision. (Show Details)

• jon requested changes to this revision.Oct 24 2022, 10:20 AM

• jon added inline comments.

services/tunnelbroker/build.rs
54–55 ↗	(On Diff #17873)	should also ask cargo to rebuild if changed

This revision now requires changes to proceed.Oct 24 2022, 10:20 AM

Harbormaster completed remote builds in B13014: Diff 17873.Oct 24 2022, 10:24 AM

Cargo re-run if proto file was changed is added.

• max marked an inline comment as done.Oct 24 2022, 10:27 AM

• max added inline comments.

services/tunnelbroker/build.rs
54–55 ↗	(On Diff #17873)	should also ask cargo to rebuild if changed Good catch! Thanks, @jon. I've added it.

Harbormaster completed remote builds in B13017: Diff 17876.Oct 24 2022, 10:37 AM

• max added a child revision: D5477: [services] Tunnelbroker - Adding Tonic gRPC server with empty handlers.Oct 25 2022, 10:34 AM

• max mentioned this in D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.Oct 26 2022, 2:48 AM

• jon accepted this revision.Oct 26 2022, 1:50 PM

This revision is now accepted and ready to land.Oct 26 2022, 1:50 PM

• max mentioned this in rCOMM3fb5533c5d5d: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust….Nov 7 2022, 6:11 AM

• max removed a parent revision: D5461: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run `cargo`.Nov 7 2022, 6:24 AM

Rebasing on master changes.

Harbormaster failed remote builds in B13212: Diff 18129!Nov 7 2022, 6:41 AM

Android CI build error is unrelated to these changes, and I will land this diff.

This revision was landed with ongoing or failed builds.Nov 7 2022, 6:45 AM

Closed by commit rCOMM38f3bc4c4abe: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs` (authored by • max). · Explain Why

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM38f3bc4c4abe: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.

• max removed a child revision: D5477: [services] Tunnelbroker - Adding Tonic gRPC server with empty handlers.Nov 7 2022, 10:19 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

4 lines

Diff 18130

services/tunnelbroker/build.rs

Loading...