Paths

Table of Contentst

[services][blob] Introduce database client
ClosedPublic
Actions

Authored by bartek on Nov 18 2022, 6:19 PM.

Details

Reviewers

varun
• jon
tomek
marcin

Commits

rCOMM7790e0898b88: [services][blob] Introduce database client

Summary

Introduced DynamoDB database client - the same way as it is implemented in Identity Service.

The interface of the C++ implementation is here.

Depends on D5680

Test Plan

Only ensured that build does not fail.

Diff Detail

Repository

rCOMM Comm

Branch

barthap/blob-rust

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bartek created this revision.Nov 18 2022, 6:19 PM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptNov 18 2022, 6:19 PM

Harbormaster completed remote builds in B13572: Diff 18591.Nov 18 2022, 6:33 PM

bartek added a child revision: D5682: [services][blob] Provide S3 and DB to service, add more constants.Nov 18 2022, 6:35 PM

bartek published this revision for review.Nov 18 2022, 6:44 PM

bartek edited the summary of this revision. (Show Details)

ashoat added 1 blocking reviewer(s): varun.Nov 18 2022, 8:59 PM

varun accepted this revision.Nov 22 2022, 5:53 PM

This revision is now accepted and ready to land.Nov 22 2022, 5:53 PM

tomek accepted this revision.Nov 23 2022, 9:33 AM

tomek added inline comments.Nov 23 2022, 9:53 AM

services/blob/src/database.rs
33	Shouldn't we use `anyhow` `Result`?

Rebase, use short form of Result

Harbormaster completed remote builds in B13723: Diff 18803.Nov 24 2022, 8:58 AM

Closed by commit rCOMM7790e0898b88: [services][blob] Introduce database client. · Explain WhyNov 29 2022, 1:15 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM7790e0898b88: [services][blob] Introduce database client.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

database.rs

77 lines

main.rs

1 line

Diff 18591

View Options

services/blob/src/database.rs