Page MenuHomePhabricator
Differential D5751

[native] Fix issue with `ColorSelector` header color
ClosedPublic
Actions

Authored by atul on Nov 28 2022, 11:43 PM.
Tags
None
Referenced Files
F3513137: D5751.id18907.diff
Sat, Dec 21, 10:49 PM
F3513082: D5751.id18975.diff
Sat, Dec 21, 10:20 PM
F3511901: D5751.diff
Sat, Dec 21, 5:22 PM
Unknown Object (File)
Nov 6 2024, 7:05 PM
Unknown Object (File)
Nov 2 2024, 10:44 PM
Unknown Object (File)
Nov 2 2024, 10:44 PM
Unknown Object (File)
Nov 2 2024, 10:44 PM
Unknown Object (File)
Nov 2 2024, 10:44 PM
View All 96 Files
Subscribers
ashoat
kamil

Details

Reviewers
kamil
tomek
marcin
ginsu
rohan
varun
ashoat
Commits
rCOMM3c29c0069646: [native] Fix issue with `ColorSelector` header color
Summary

Context: https://linear.app/comm/issue/ENG-2354/header-in-color-select-modal-barely-visible-on-dark-mode

Here's where I caused the regression: https://phab.comm.dev/D5619#171440

Basically I set color to modalForegroundLabel in a StyleSheet instead of in an unboundStyles object that gets "bound" with the useStyles(...) hook.

Thanks @kamil for catching this issue.

Test Plan

Here's how it looks in light mode + dark mode:

Simulator Screen Shot - Alice - 2022-11-28 at 23.37.59.png (2×1 px, 165 KB)

Simulator Screen Shot - Alice - 2022-11-28 at 23.37.48.png (2×1 px, 167 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 28 2022, 11:43 PM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 28 2022, 11:43 PM
atul published this revision for review.Nov 28 2022, 11:43 PM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B13814: Diff 18907.Nov 28 2022, 11:56 PM
ashoat accepted this revision.Nov 29 2022, 6:39 AM
This revision is now accepted and ready to land.Nov 29 2022, 6:39 AM
atul updated this revision to Diff 18975.Nov 29 2022, 12:41 PM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 29 2022, 12:42 PM
Closed by commit rCOMM3c29c0069646: [native] Fix issue with `ColorSelector` header color (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM3c29c0069646: [native] Fix issue with `ColorSelector` header color.
Harbormaster completed remote builds in B13854: Diff 18975.Nov 29 2022, 12:54 PM

Revision Contents
Changeset List

PathSize
native/
components/
10 lines

Diff 18907

View Options

native/components/color-selector.react.js

Loading...