[native/rust_library] Refactor Tonic client utility function names for Identity service
ClosedPublic
Actions

Authored by • max on Dec 21 2022, 4:53 AM.

Details

Reviewers

varun
• jon

Commits

rCOMM7b335fb66032: [native/rust_library] Refactor Tonic client utility function names for Identity…

Summary

This diff introduces refactoring the Tonic client utility function names for the Identity service in a Rust native library.
As we are using a single Rust library for the native which will contain clients and helper functions for all services we should refactor the Identity service-related function names to be more specific.
This refactoring adds an identity prefix to the function names.

Linear task: ENG-1333

Test Plan

Rust library and native app are successfully built.

Diff Detail

Repository

rCOMM Comm

Branch

restruct-native-rust-library-refactor-functions

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Dec 21 2022, 4:53 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 21 2022, 4:53 AM

• max added a parent revision: D5967: [native/rust_library] Refactor Tonic client function name for Identity service.Dec 21 2022, 4:55 AM

• max added a child revision: D5969: [native/rust_library] Adding CXX bridge names for C++ Identity service client functions.

Harbormaster completed remote builds in B14615: Diff 19935.Dec 21 2022, 5:07 AM

• max retitled this revision from [native/rust_library] Refactor Tonic client function names for Identity service to [native/rust_library] Refactor Tonic client utility function names for Identity service.Dec 21 2022, 5:10 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, • jon.

• max added inline comments.

native/native_rust_library/src/lib.rs
16–19	To not rename these functions it's better to call them directly with the parent name like: `identity_client::get_user_id`, this will add more clearance.