Paths

Table of Contentst

Differential D5999

[native/rust_library] Adding `sign_string_with_private_key` function to crypto tools
AcceptedPublic
Actions

Authored by • max on Dec 22 2022, 7:12 AM.

Tags

None

Referenced Files

	F3492634: D5999.id20076.diff
	Thu, Dec 19, 12:56 AM

	F3492564: D5999.id20255.diff
	Thu, Dec 19, 12:37 AM

	F3492562: D5999.id20299.diff
	Thu, Dec 19, 12:36 AM

	F3492170: D5999.diff
	Wed, Dec 18, 10:23 PM

	F3491018: D5999.id20299.diff
	Wed, Dec 18, 6:16 PM

	F3491016: D5999.id20255.diff
	Wed, Dec 18, 6:16 PM

	F3491015: D5999.id20076.diff
	Wed, Dec 18, 6:16 PM

	F3491014: D5999.id20026.diff
	Wed, Dec 18, 6:16 PM

Subscribers

Details

Reviewers

• jon
bartek

Commits

rCOMMb637b2bcb09c: [native/rust_library] Adding `sign_string_with_private_key` function to crypto…

Summary

This diff introduces adding the sign_string_with_private_key function to crypto tools. This function gets the string to be signed and the private key and returns a sha256 signature. We will use this function in the Tunnelbroker client's new session creation because we need to provide the signed string to the Tunnelbroker to prove the ownership of the keys.

Linear task: ENG-1333

Test Plan

Successfully passing the unit test for this function in D6000

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Dec 22 2022, 7:12 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 22 2022, 7:12 AM

• max added parent revisions: D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies, D5997: [native/rust_library] Adding of the Tunnelbroker Tonic client initialization.Dec 22 2022, 7:13 AM

Harbormaster failed remote builds in B14686: Diff 20026!Dec 22 2022, 7:16 AM

• max added a child revision: D6000: [native/rust_library] Adding unit test for the `sign_string_with_private_key` function.Dec 22 2022, 7:43 AM

• max mentioned this in D5998: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.Dec 22 2022, 8:00 AM

Rebasing on parent changes.

• max edited the summary of this revision. (Show Details)Dec 22 2022, 8:09 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • jon, bartek.

• max published this revision for review.Dec 22 2022, 8:15 AM

Harbormaster completed remote builds in B14689: Diff 20029.Dec 22 2022, 8:16 AM

• max edited the test plan for this revision. (Show Details)Dec 22 2022, 8:21 AM

ashoat added inline comments.Dec 22 2022, 8:50 AM

native/native_rust_library/src/crypto_tools.rs
42 ↗	(On Diff #20029)	This should called a `nonce`

Change string_to_be_signed to be nonce.

• max marked an inline comment as done.Dec 23 2022, 10:50 AM

• max added inline comments.

native/native_rust_library/src/crypto_tools.rs
42 ↗	(On Diff #20029)	This should called a `nonce` Fixed.

Harbormaster completed remote builds in B14721: Diff 20076.Dec 23 2022, 11:04 AM

• jon accepted this revision.Dec 23 2022, 2:29 PM

This revision is now accepted and ready to land.Dec 23 2022, 2:29 PM

• max added a child revision: D6039: [native/rust_library] Tunnelbroker client - Adding of the `get_nonce_to_sign` function.Dec 27 2022, 3:35 AM

• max mentioned this in D6039: [native/rust_library] Tunnelbroker client - Adding of the `get_nonce_to_sign` function.Dec 27 2022, 3:46 AM

• max mentioned this in D6040: [native/rust_library] Tunnelbroker client - Adding of the `get_new_session_id` function.Dec 27 2022, 3:51 AM

tomek mentioned this in D5947: [services] Tunnelbroker - Modify server handler to use Rust signature verification.Dec 27 2022, 3:53 AM

• max mentioned this in rCOMMd2fd0f2e9fba: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.Dec 28 2022, 10:36 AM

Rebasing and merging on master changes.

Harbormaster completed remote builds in B14850: Diff 20255.Dec 28 2022, 11:20 AM

Closed by commit rCOMMb637b2bcb09c: [native/rust_library] Adding `sign_string_with_private_key` function to crypto… (authored by • max). · Explain WhyDec 29 2022, 2:08 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMb637b2bcb09c: [native/rust_library] Adding `sign_string_with_private_key` function to crypto….

• max added a reverting change: D6089: [native] Reverting D5999 and D6000.Dec 29 2022, 2:43 AM

• max added a reverting change: rCOMMe01e78fb8b04: [native] Reverting D5999 and D6000.Dec 29 2022, 8:12 AM

This diff will be landed after ENG-2563 will be resolved.

This revision is now accepted and ready to land.Dec 29 2022, 8:12 AM

• max mentioned this in rCOMMa5ec4c770533: [native/rust_library] Adding `openssl`, `base64`, `anyhow` dependencies.Jan 4 2023, 9:39 AM

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

crypto_tools.rs

14 lines

Diff 20299

native/native_rust_library/src/crypto_tools.rs

Loading...