[native] Fix scrolling in screen inside StackNavigator on Android
ClosedPublic
Actions

Authored by ashoat on Jan 27 2023, 8:42 AM.

Details

Reviewers

• max
inka
tomek
bartek
• przemek
kamil

Commits

rCOMM74995df61c39: [native] Fix scrolling in screen inside StackNavigator on Android

Summary

This fixes ENG-2845, which I introduced in D6331.

It looks like gestureEnabled breaks scrolling on Android. I found a ton of GitHub issues discussing this, and the solution in all of them was to use FlatList from react-native-gesture-handler.

In this diff I went through every FlatList or ScrollView used in a StackNavigator where we have introduced gestureEnabled in D6331 (Chat and Profile), and I switched them to use FlatList from react-native-gesture-handler.

Test Plan

First, I ran git grep ScrollView and git grep FlatList in native/chat and native/profile to try to find any examples of cases that needed to be changed
I deployed the app to a physical Android device to verify that scrolling still worked for all of the interfaces I fixed up

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 27 2023, 8:42 AM

Herald added a subscriber: atul. · View Herald TranscriptJan 27 2023, 8:42 AM

ashoat added inline comments.Jan 27 2023, 8:44 AM

native/chat/chat-list.react.js
218	It's okay to use `any` here because we immediately cast the result to a valid type. The use of `any` is necessary to use `react-native-gesture-handler`'s `FlatList` (which doesn't have Flow types), but to type it using the Flow types for the default `react-native` `FlatList`