Page MenuHomePhabricator
Differential D6497

[native] Add native picker button to MediaGalleryKeyboard
ClosedPublic
Actions

Authored by bartek on Feb 1 2023, 9:51 AM.
Tags
None
Referenced Files
F3245474: D6497.diff
Thu, Nov 14, 6:41 PM
Unknown Object (File)
Wed, Oct 30, 5:59 AM
Unknown Object (File)
Wed, Oct 30, 5:59 AM
Unknown Object (File)
Wed, Oct 30, 5:58 AM
Unknown Object (File)
Wed, Oct 30, 5:53 AM
Unknown Object (File)
Sep 30 2024, 3:21 AM
Unknown Object (File)
Sep 30 2024, 3:21 AM
Unknown Object (File)
Sep 30 2024, 3:21 AM
View All 60 Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
inka
• przemek
ginsu
Commits
rCOMM85985c98c0e0: [native] Add native picker button to MediaGalleryKeyboard
Summary

Resolves https://linear.app/comm/issue/ENG-2560/build-component-above-keyboard-image-photosbrowse-all-photos-that

Figma design: https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=3972%3A53851&t=63ZWpVfkfvm4AHad-0

Depends on D6495

Test Plan

This is how it looks:

IMG_7891.PNG (2×1 px, 3 MB)

Diff Detail

Repository
rCOMM Comm
Branch
barthap/expo-image-picker
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Feb 1 2023, 9:51 AM
bartek held this revision as a draft.
Herald added subscribers: atul, tomek. · View Herald TranscriptFeb 1 2023, 9:51 AM
bartek edited the test plan for this revision. (Show Details)Feb 1 2023, 9:55 AM
bartek edited the test plan for this revision. (Show Details)
bartek attached a referenced file: F355749: IMG_7891.PNG. (Show Details)Feb 1 2023, 10:02 AM
Harbormaster completed remote builds in B15942: Diff 21766.Feb 1 2023, 10:07 AM
bartek published this revision for review.Feb 1 2023, 10:15 AM
ashoat accepted this revision.Feb 1 2023, 10:56 AM

Looks good! I assume you figured out the Android issues?

Please address inline comment before landing

native/media/media-gallery-keyboard.react.js
611

We typically prefer to avoid custom colors like this – it might not look good in light mode, and it breaks the design system. Can you reach out to the design team (maybe on DES-17, feel free to reopen) to figure out what color in native/themes/colors.js we can use for this? If there's no good option, then it would be good to check what the color should be in light mode and introduce it to native/themes/colors.js

bartek added inline comments.Feb 1 2023, 11:14 AM
native/media/media-gallery-keyboard.react.js
611

I took this value directly from Figma, but I suspect that when I blend it with the background color to get rid of alpha, I'll receive something very close to an existing value in colors.js.

bartek added a child revision: D6556: [native] Send native picker media directly.Feb 3 2023, 5:03 AM
ashoat removed 1 blocking reviewer(s): inka.Feb 3 2023, 4:00 PM

Unblocking so you can land. Feel free to create a follow-up task regarding the color, but ideally we can swap it with something in the design system

This revision is now accepted and ready to land.Feb 3 2023, 4:00 PM
Closed by commit rCOMM85985c98c0e0: [native] Add native picker button to MediaGalleryKeyboard (authored by bartek). · Explain WhyFeb 4 2023, 10:03 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM85985c98c0e0: [native] Add native picker button to MediaGalleryKeyboard.
bartek added a comment.Feb 4 2023, 10:09 AM
In D6497#196110, @ashoat wrote:

Unblocking so you can land. Feel free to create a follow-up task regarding the color, but ideally we can swap it with something in the design system

Landed and created https://linear.app/comm/issue/ENG-2926/revisit-native-photo-picker-button-color

Revision Contents
Changeset List

PathSize
native/
media/
78 lines

Diff 21766

View Options

native/media/media-gallery-keyboard.react.js

Loading...