Details

Reviewers

tomek
bartek
michal

Commits

rCOMM5c3e87bbdd6c: [web] Highlight drawer items

Summary

issue: https://linear.app/comm/issue/ENG-2738/highlight-drawer-item
Drawer items are supposed to be highlighted in the Chat tab, and not highlighted in the Calendar tab. The Apps tab and user settings tabs for now behave like the Chat tab, because it is still being discussed what we want to do there (https://linear.app/comm/issue/ENG-2789/make-drawer-items-in-calendar-tab-not-expandable)

Test Plan

Run the web app, check that drawer items are highlighted in the Chat, and are not in the Calendar App.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jan 25 2023, 2:48 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 25 2023, 2:48 AM

inka edited the summary of this revision. (Show Details)Jan 25 2023, 2:50 AM

inka added reviewers: tomek, bartek, michal.

inka added parent revisions: D6294: [web] Change drawer items styling to allow full-width highlights, D6292: [web] Make drawer items react based on the current app.

inka attached a referenced file: F343808: Screen Recording 2023-01-25 at 11.31.57.mov. (Show Details)

Harbormaster completed remote builds in B15629: Diff 21303.Jan 25 2023, 3:02 AM

inka requested review of this revision.Jan 25 2023, 3:02 AM

Looks ok, but I think we should reconsider the design a little bit. For me, it feels like clicking on a community in calendar app should result in the community being highlighted.

This revision is now accepted and ready to land.Jan 26 2023, 6:37 AM

I agree that the community should be highlighted when pressed in the calendar

Okay, i created an issue to ask the design team how they want it done.

inka mentioned this in D6668: [web] Fix drawer higlight glitch.Feb 9 2023, 2:19 AM

Rebase

Harbormaster failed remote builds in B16417: Diff 22454!Feb 13 2023, 7:34 AM

Rebase

Harbormaster completed remote builds in B16437: Diff 22474.Feb 13 2023, 9:52 AM

Rebase

Harbormaster completed remote builds in B16495: Diff 22542.Feb 14 2023, 3:41 AM

Closed by commit rCOMM5c3e87bbdd6c: [web] Highlight drawer items (authored by • InkaSokolowska). · Explain WhyFeb 14 2023, 5:02 AM

This revision was automatically updated to reflect the committed changes.