[lib] Limit maximum chat name to prevent error
ClosedPublic
Actions

Authored by • kuba on Feb 15 2023, 2:12 AM.

Details

Reviewers

tomek
inka
michal

Commits

rCOMMca3c8384e847: [lib] Limit maximum chat name to prevent error

Summary

When you set too long a chat name (>191 characters) it resulted in a server error (SQL name field limit).
Added limits to GUI: native and web. Validating the result on the keyserver before it reaches SQL.

Original issue

Test Plan

Tested on iOS, Android, and the web app.
Now you can't input more characters than the limit set.
If you do (older app version) the server throws error (before it reaches SQL).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• kuba created this revision.Feb 15 2023, 2:12 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 15 2023, 2:12 AM

• kuba edited the summary of this revision. (Show Details)Feb 15 2023, 2:17 AM

• kuba edited the test plan for this revision. (Show Details)

• kuba added reviewers: inka, michal.

• kuba edited the summary of this revision. (Show Details)Feb 15 2023, 2:21 AM

Harbormaster completed remote builds in B16530: Diff 22614.Feb 15 2023, 2:28 AM

• kuba requested review of this revision.Feb 15 2023, 2:28 AM

Looks good to me, but feel free to assign any blocking reviewers if you want.

This revision is now accepted and ready to land.Feb 15 2023, 4:49 AM

ashoat added inline comments.Feb 15 2023, 7:37 AM

web/modals/input.react.js
8–23 ↗	(On Diff #22614)	I'm a little confused about `BaseInputProps` vs. `InputProps`. I did some research and it looks like this is only used for convenience of defining `Props` in `PasswordInput`, so I guess it's fine...