Page MenuHomePhabricator
Differential D6892

[keyserver] Extend ios notifs to handle macos
ClosedPublic
Actions

Authored by michal on Feb 24 2023, 9:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 9:39 PM
Unknown Object (File)
Sun, Oct 27, 5:33 PM
Unknown Object (File)
Sun, Oct 20, 1:22 AM
Unknown Object (File)
Sat, Oct 19, 3:01 PM
Unknown Object (File)
Sat, Oct 19, 3:01 PM
Unknown Object (File)
Sat, Oct 19, 12:49 PM
Unknown Object (File)
Sat, Oct 19, 12:49 PM
Unknown Object (File)
Oct 1 2024, 7:32 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
inka
kamil
ashoat
Commits
rCOMMd0f63f42e64b: [keyserver] Extend ios notifs to handle macos
Summary

We can reuse most of out already existing code for macOS notifs. This diff mostly just replaces codeVersion with full platformDetails so we can pass a platform and change for example the apn topic depending if we are sending the notifcation to the ios or macos.

Depends on D6891

Test Plan

Check if notifications still work on ios

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.Feb 24 2023, 9:43 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 24 2023, 9:43 AM
michal updated this revision to Diff 23070.Feb 24 2023, 9:54 AM

Update

Harbormaster completed remote builds in B16887: Diff 23069.Feb 24 2023, 9:58 AM
michal added a child revision: D6893: [keyserver] Send macos notifications.Feb 24 2023, 10:09 AM
Harbormaster completed remote builds in B16888: Diff 23070.Feb 24 2023, 10:10 AM
michal requested review of this revision.Feb 24 2023, 10:10 AM
ashoat accepted this revision.Feb 26 2023, 4:43 AM
ashoat added inline comments.
keyserver/src/push/send.js
177 ↗(On Diff #23070)

We construct this already on line 167. Instead of doing twice, maybe we should assign to a variable?

This revision is now accepted and ready to land.Feb 26 2023, 4:43 AM
michal updated this revision to Diff 23247.Feb 28 2023, 9:29 AM

Extract platformDetails variables.

Harbormaster completed remote builds in B16993: Diff 23247.Feb 28 2023, 9:49 AM
Closed by commit rCOMMd0f63f42e64b: [keyserver] Extend ios notifs to handle macos (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMar 1 2023, 12:55 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMd0f63f42e64b: [keyserver] Extend ios notifs to handle macos.

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
22 lines
9 lines
29 lines
7 lines

Diff 23069

View Options

keyserver/src/push/providers.js

Loading...
View Options

keyserver/src/push/rescind.js

Loading...
View Options

keyserver/src/push/send.js

Loading...
View Options

keyserver/src/push/utils.js

Loading...