Page MenuHomePhabricator

[lib] Make CreateSidebar notifs say when the OP tags the notif recipient
ClosedPublic

Authored by ashoat on Feb 23 2023, 1:17 PM.
Tags
None
Referenced Files
F3513195: D6874.diff
Sat, Dec 21, 11:07 PM
Unknown Object (File)
Tue, Dec 3, 11:00 PM
Unknown Object (File)
Fri, Nov 22, 1:58 PM
Unknown Object (File)
Oct 27 2024, 2:04 PM
Unknown Object (File)
Oct 18 2024, 3:38 PM
Unknown Object (File)
Oct 18 2024, 5:18 AM
Unknown Object (File)
Oct 18 2024, 5:17 AM
Unknown Object (File)
Oct 18 2024, 5:17 AM
Subscribers

Details

Summary

Typically you would only receive a CreateSidebar notif if you are the author of the OP. However, some earlier diffs introduced a new scenario: if you are tagged in the OP, you will be auto-added to the sidebar at creation time, and as such will receive the CreateSidebar notif.

To make sure the notif recipient isn't confused by the notif, this diff adds some text to the notification to clarify this.

Depends on D6873

Test Plan

I confirmed that a sidebar started in response to a text message that @-mentions somebody will result in the @-mentioned user receiving a custom notif that ends with "that tagged you"

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable