Actually send the notification to all macos devices. One things that is different is that we don't include text for alert notif so it doesn't display automatically by macos but we handle the visible notification ourselves. More information in ENG-3056.
Details
Details
- Reviewers
tomek inka kamil ashoat - Commits
- rCOMM8a4bdc4cabdc: [keyserver] Send macos notifications
Tested with the next diff, if the notifications are sent correctly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
It looks like you're adding support for sending push notifs, but support is still missing for rescinds and for updateBadgeCount. Rescinds may be hard but updateBadgeCount should be easy.
Before landing, can you create Linear tasks for each?
| keyserver/src/push/send.js | ||
|---|---|---|
| 546 ↗ | (On Diff #23071) | Can you add a code comment explaining why we don't include body or sounds for macOS? |
| keyserver/src/push/send.js | ||
|---|---|---|
| 619 ↗ | (On Diff #23260) | Nit |