Paths

Table of Contentst

Differential D6938

[lib] Include fact that you were tagged in sidebar creation message
ClosedPublic
Actions

Authored by ashoat on Mar 2 2023, 2:05 PM.

Tags

None

Referenced Files

	F3398213: D6938.id23382.diff
	Sun, Dec 1, 9:48 PM

	Unknown Object (File)
	Sun, Nov 24, 2:31 AM

	Unknown Object (File)
	Oct 27 2024, 2:33 PM

	Unknown Object (File)
	Oct 21 2024, 3:56 PM

	Unknown Object (File)
	Oct 21 2024, 12:37 PM

	Unknown Object (File)
	Oct 18 2024, 9:53 AM

	Unknown Object (File)
	Oct 18 2024, 9:52 AM

	Unknown Object (File)
	Oct 18 2024, 8:56 AM

Subscribers

Details

Reviewers

Commits

rCOMMe861dc492aaa: [lib] Include fact that you were tagged in sidebar creation message

Summary

In the stack ending with D6874, I made it so that if you were @-mentioned in the OP, you would get a notif that ended with "that tagged you". (Part 1 from this Linear comment.)

This diff completes the stack that makes it so if you were @-mentioned in the message that triggers the creation of the sidebar, you will get a notif that ends with "and tagged you". (Part 2 from this Linear comment.)

Depends on D6937

Test Plan

Flow, and tested in combination with the next diffs to confirm that getting @-tagged in a message that triggers the creation of a sidebar will update the SIDEBAR_CREATION notif
to be suffixed with "and tagged you"

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 2 2023, 2:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 2 2023, 2:05 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 2 2023, 2:15 PM

Harbormaster failed remote builds in B17072: Diff 23374!

Rebase

Harbormaster completed remote builds in B17078: Diff 23382.Mar 2 2023, 3:52 PM

ashoat requested review of this revision.Mar 2 2023, 3:52 PM

atul accepted this revision.Mar 3 2023, 11:26 AM

atul added inline comments.

lib/shared/messages/text-message-spec.js
192–230 ↗	(On Diff #23382)	Thanks for including a comment explaining each branch here

This revision is now accepted and ready to land.Mar 3 2023, 11:26 AM

Closed by commit rCOMMe861dc492aaa: [lib] Include fact that you were tagged in sidebar creation message (authored by ashoat). · Explain WhyMar 3 2023, 12:11 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe861dc492aaa: [lib] Include fact that you were tagged in sidebar creation message.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

message-spec.js

2 lines

text-message-spec.js

66 lines

9 lines

Diff 23374

lib/shared/messages/message-spec.js

Loading...

lib/shared/messages/text-message-spec.js

Loading...

lib/shared/notif-utils.js

Loading...