Page MenuHomePhabricator
Differential D6980

Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash"
ClosedPublic
Actions

Authored by marcin on Mar 7 2023, 5:37 AM.
Tags
None
Referenced Files
F1803818: D6980.id23493.diff
Mon, May 20, 6:49 PM
Unknown Object (File)
Fri, May 17, 12:04 PM
Unknown Object (File)
Mon, May 13, 7:32 PM
Unknown Object (File)
Mon, May 13, 7:32 PM
Unknown Object (File)
Mon, May 13, 7:32 PM
Unknown Object (File)
Mon, May 13, 7:32 PM
Unknown Object (File)
Mon, May 13, 7:29 PM
Unknown Object (File)
Sat, May 11, 1:44 PM
View All 72 Files
Subscribers
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM2453e10d5b13: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash"
Summary

This reverts commit 980305ee4c956ab22e1577a0d1d810c269e0d80b.

Test Plan

Build Android app and ensure the crash fixed by counterpart diff reoccurs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
99 lines
Notifications/
BackgroundDataStorage/
6 lines
16 lines

Diff 23493

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

Loading...
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp

Loading...