Page MenuHomePhabricator

[lib][keyserver] Introduce new threadPermissions types for reactions
ClosedPublic

Authored by ashoat on Mar 14 2023, 8:07 PM.
Tags
None
Referenced Files
F3524305: D7073.id23779.diff
Mon, Dec 23, 12:08 PM
F3523443: D7073.id23746.diff
Mon, Dec 23, 9:18 AM
F3521941: D7073.diff
Mon, Dec 23, 5:22 AM
Unknown Object (File)
Fri, Dec 6, 6:10 AM
Unknown Object (File)
Thu, Dec 5, 2:23 AM
Unknown Object (File)
Thu, Dec 5, 2:23 AM
Unknown Object (File)
Sun, Dec 1, 5:01 AM
Unknown Object (File)
Nov 20 2024, 6:12 PM
Subscribers

Details

Summary

I want to allow people to react in announcement channels even though they can't send messages, so I'm introducing a new threadPermissions type.

This diff introduces the type, adds it to all roles except GENESIS members, and adds a new migration to populate it.

Test Plan

I tested this in combination with the next diff by:

  1. Running the migration by restarting the keyserver after introducing it and making sure it runs successfully
  2. Testing reacting as a member (non-admin) to a message in a COMMUNITY_ANNOUNCEMENT_ROOT community root. I don't have permission to send messages, but I can react on both native and web. I didn't need to log out / back in on native, which indicates the the updatesTypes.UPDATE_THREAD updates were propagated correctly by the migration

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage