Paths

Table of Contentst

-
.dockerignore
-
keyserver/
-
Dockerfile
-
native/
-
expo-modules/aes-crypto/
-
aes-crypto/
-
android/
-
build.gradle
-
src/main/
-
main/
-
AndroidManifest.xml
-
java/app/comm/android/aescrypto/
-
app/
-
comm/
-
android/
-
aescrypto/
-
AESCryptoModule.kt
-
expo-module.config.json
-
ios/
-
AESCrypto.podspec
-
AESCryptoModule.swift
-
package.json
-
ios/
-
Podfile.lock
-
package.json
-
utils/
-
aes-crypto-module.js
-
package.json

[native] Create AESCrypto Expo module
ClosedPublic
Actions

Authored by bartek on Mar 8 2023, 9:51 AM.

Details

Reviewers

ashoat
marcin
atul

Commits

rCOMM8735eb5f5924: [native] Create AESCrypto Expo module

Summary

Created an Expo module that will handle AES encryption operations on native.

Inspired by D5932 that added android-lifecycle expo module.

Test Plan

Run yarn cleaninstall.

Both iOS and Android projects build and run successfully.

import { hello } from './utils/aes-crypto-module.js';

console.log(hello());

displays "Hello world! 👋"

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Mar 8 2023, 9:51 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMar 8 2023, 9:51 AM

bartek added a child revision: D7004: [native][AES] Implement generateKey function.Mar 8 2023, 9:56 AM

Harbormaster completed remote builds in B17184: Diff 23535.Mar 8 2023, 10:07 AM

bartek published this revision for review.Mar 8 2023, 10:19 AM

bartek edited the test plan for this revision. (Show Details)

bartek added 1 blocking reviewer(s): ashoat.

bartek added inline comments.

native/expo-modules/aes-crypto/ios/AESCrypto.podspec
7–12 ↗	(On Diff #23535)	Unfortunately, these values are required or `pod install` fails.

ashoat accepted this revision.Mar 8 2023, 10:28 AM

ashoat added inline comments.

native/expo-modules/aes-crypto/package.json
3 ↗	(On Diff #23535)	The version in the Gradle file appears to be 0.1.0... should we make them consistent?

This revision is now accepted and ready to land.Mar 8 2023, 10:28 AM

bartek added inline comments.Mar 9 2023, 5:15 AM

native/expo-modules/aes-crypto/package.json
3 ↗	(On Diff #23535)	Doesn't matter. AndroidLifecycle has the same inconsistency.

Rebase before landing

Harbormaster completed remote builds in B17397: Diff 23839.Mar 20 2023, 7:10 AM

Closed by commit rCOMM8735eb5f5924: [native] Create AESCrypto Expo module (authored by bartek). · Explain WhyMar 20 2023, 7:15 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8735eb5f5924: [native] Create AESCrypto Expo module.

Revision Contents
Changeset List

Path

Size

.dockerignore

1 line

keyserver/

Dockerfile

2 lines

native/

expo-modules/

aes-crypto/

android/

build.gradle

91 lines

src/

main/

AndroidManifest.xml

2 lines

java/

app/

comm/

android/

aescrypto/

AESCryptoModule.kt

14 lines

expo-module.config.json

9 lines

ios/

AESCrypto.podspec

27 lines

AESCryptoModule.swift

11 lines

package.json

17 lines

ios/

Podfile.lock

6 lines

package.json

1 line

utils/

aes-crypto-module.js

11 lines

package.json

1 line

Diff 23839

View Options

.dockerignore

Show All 12 Lines	import {
entryRevisionFetchResponder,		entryRevisionFetchResponder,
entryCreationResponder,		entryCreationResponder,
entryUpdateResponder,		entryUpdateResponder,
entryDeletionResponder,		entryDeletionResponder,
entryRestorationResponder,		entryRestorationResponder,
calendarQueryUpdateResponder,		calendarQueryUpdateResponder,
} from './responders/entry-responders.js';		} from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js';		import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js';		import {
		getSessionPublicKeysResponder,
		getOlmSessionInitializationDataResponder,
		} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js';		import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js';		import { messageReportCreationResponder } from './responders/message-report-responder.js';
import {		import {
textMessageCreationResponder,		textMessageCreationResponder,
messageFetchResponder,		messageFetchResponder,
multimediaMessageCreationResponder,		multimediaMessageCreationResponder,
reactionMessageCreationResponder,		reactionMessageCreationResponder,
editMessageCreationResponder,		editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Lines	const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: {		update_user_avatar: {
responder: updateUserAvatarResponder,		responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies,		requiredPolicies: baseLegalPolicies,
},		},
upload_media_metadata: {		upload_media_metadata: {
responder: uploadMediaMetadataResponder,		responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies,		requiredPolicies: baseLegalPolicies,
},		},
		get_olm_session_initialization_data: {
		responder: getOlmSessionInitializationDataResponder,
		requiredPolicies: [],
		},
};		};

export { jsonEndpoints };		export { jsonEndpoints };

View Options

keyserver/Dockerfile

Show All 12 Lines	import {
entryRevisionFetchResponder,		entryRevisionFetchResponder,
entryCreationResponder,		entryCreationResponder,
entryUpdateResponder,		entryUpdateResponder,
entryDeletionResponder,		entryDeletionResponder,
entryRestorationResponder,		entryRestorationResponder,
calendarQueryUpdateResponder,		calendarQueryUpdateResponder,
} from './responders/entry-responders.js';		} from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js';		import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js';		import {
		getSessionPublicKeysResponder,
		getOlmSessionInitializationDataResponder,
		} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js';		import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js';		import { messageReportCreationResponder } from './responders/message-report-responder.js';
import {		import {
textMessageCreationResponder,		textMessageCreationResponder,
messageFetchResponder,		messageFetchResponder,
multimediaMessageCreationResponder,		multimediaMessageCreationResponder,
reactionMessageCreationResponder,		reactionMessageCreationResponder,
editMessageCreationResponder,		editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Lines	const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: {		update_user_avatar: {
responder: updateUserAvatarResponder,		responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies,		requiredPolicies: baseLegalPolicies,
},		},
upload_media_metadata: {		upload_media_metadata: {
responder: uploadMediaMetadataResponder,		responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies,		requiredPolicies: baseLegalPolicies,
},		},
		get_olm_session_initialization_data: {
		responder: getOlmSessionInitializationDataResponder,
		requiredPolicies: [],
		},
};		};

export { jsonEndpoints };		export { jsonEndpoints };

View Options

native/expo-modules/aes-crypto/android/build.gradle

Show All 12 Lines	import {
entryRevisionFetchResponder,		entryRevisionFetchResponder,
entryCreationResponder,		entryCreationResponder,
entryUpdateResponder,		entryUpdateResponder,
entryDeletionResponder,		entryDeletionResponder,
entryRestorationResponder,		entryRestorationResponder,
calendarQueryUpdateResponder,		calendarQueryUpdateResponder,
} from './responders/entry-responders.js';		} from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js';		import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js';		import {
		getSessionPublicKeysResponder,
		getOlmSessionInitializationDataResponder,
		} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js';		import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js';		import { messageReportCreationResponder } from './responders/message-report-responder.js';
import {		import {
textMessageCreationResponder,		textMessageCreationResponder,
messageFetchResponder,		messageFetchResponder,
multimediaMessageCreationResponder,		multimediaMessageCreationResponder,
reactionMessageCreationResponder,		reactionMessageCreationResponder,
editMessageCreationResponder,		editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Lines	const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: {		update_user_avatar: {
responder: updateUserAvatarResponder,		responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies,		requiredPolicies: baseLegalPolicies,
},		},
upload_media_metadata: {		upload_media_metadata: {
responder: uploadMediaMetadataResponder,		responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies,		requiredPolicies: baseLegalPolicies,
},		},
		get_olm_session_initialization_data: {
		responder: getOlmSessionInitializationDataResponder,
		requiredPolicies: [],
		},
};		};

export { jsonEndpoints };		export { jsonEndpoints };

View Options

native/expo-modules/aes-crypto/android/src/main/AndroidManifest.xml

Show All 12 Lines	import {
entryRevisionFetchResponder,		entryRevisionFetchResponder,
entryCreationResponder,		entryCreationResponder,
entryUpdateResponder,		entryUpdateResponder,
entryDeletionResponder,		entryDeletionResponder,
entryRestorationResponder,		entryRestorationResponder,
calendarQueryUpdateResponder,		calendarQueryUpdateResponder,
} from './responders/entry-responders.js';		} from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js';		import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js';		import {
		getSessionPublicKeysResponder,
		getOlmSessionInitializationDataResponder,
		} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js';		import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js';		import { messageReportCreationResponder } from './responders/message-report-responder.js';
import {		import {
textMessageCreationResponder,		textMessageCreationResponder,
messageFetchResponder,		messageFetchResponder,
multimediaMessageCreationResponder,		multimediaMessageCreationResponder,
reactionMessageCreationResponder,		reactionMessageCreationResponder,
editMessageCreationResponder,		editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Lines	const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: {		update_user_avatar: {
responder: updateUserAvatarResponder,		responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies,		requiredPolicies: baseLegalPolicies,
},		},
upload_media_metadata: {		upload_media_metadata: {
responder: uploadMediaMetadataResponder,		responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies,		requiredPolicies: baseLegalPolicies,
},		},
		get_olm_session_initialization_data: {
		responder: getOlmSessionInitializationDataResponder,
		requiredPolicies: [],
		},
};		};

export { jsonEndpoints };		export { jsonEndpoints };