Page MenuHomePhabricator
Differential D7276

[web] render thread avatars in thread picker modal
ClosedPublic
Actions

Authored by ginsu on Apr 3 2023, 2:02 AM.
Tags
None
Referenced Files
F3523364: D7276.id24631.diff
Mon, Dec 23, 9:06 AM
F3523193: D7276.id24614.diff
Mon, Dec 23, 8:41 AM
F3521767: D7276.diff
Mon, Dec 23, 4:41 AM
Unknown Object (File)
Sun, Dec 8, 1:57 AM
Unknown Object (File)
Thu, Dec 5, 8:40 PM
Unknown Object (File)
Thu, Dec 5, 8:40 PM
Unknown Object (File)
Thu, Dec 5, 8:40 PM
Unknown Object (File)
Thu, Dec 5, 8:40 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMbd4639ba9a22: [web] render thread avatars in thread picker modal
Summary

render thread avatars in the calendar thread picker modal

Depends on D7275

Test Plan

Please view the screenshots below to see the changes I made:

Before:

Screenshot 2023-04-03 at 4.59.16 AM.png (2×3 px, 870 KB)

After:

Screenshot 2023-04-03 at 5.01.39 AM.png (2×3 px, 810 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 3 2023, 2:02 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 3 2023, 2:02 AM
ginsu edited the summary of this revision. (Show Details)Apr 3 2023, 2:03 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7275: [web] render thread avatars in thread subchannel/sidebar modals.
ginsu attached a referenced file: F459834: Screenshot 2023-04-03 at 5.01.39 AM.png. (Show Details)
ginsu attached a referenced file: F459833: Screenshot 2023-04-03 at 4.59.16 AM.png. (Show Details)
ginsu added a child revision: D7277: [web] gate avatars rendering.Apr 3 2023, 2:17 AM
Harbormaster completed remote builds in B17918: Diff 24548.Apr 3 2023, 2:17 AM
ginsu requested review of this revision.Apr 3 2023, 2:17 AM
atul accepted this revision.Apr 3 2023, 12:07 PM
This revision is now accepted and ready to land.Apr 3 2023, 12:07 PM
ginsu updated this revision to Diff 24614.Apr 4 2023, 11:11 AM

rebase before landing

Harbormaster completed remote builds in B17977: Diff 24614.Apr 4 2023, 11:41 AM
Closed by commit rCOMMbd4639ba9a22: [web] render thread avatars in thread picker modal (authored by ginsu). · Explain WhyApr 4 2023, 11:53 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMbd4639ba9a22: [web] render thread avatars in thread picker modal.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
6 lines
11 lines

Diff 24548

View Options

web/modals/threads/thread-picker-modal.css

Loading...
View Options

web/modals/threads/thread-picker-modal.react.js

Loading...