Page MenuHomePhabricator
Differential D7254

[native] Cache decrypted media
ClosedPublic
Actions

Authored by bartek on Mar 30 2023, 7:07 AM.
Tags
None
Referenced Files
F1791333: D7254.id24717.diff
Sun, May 19, 12:13 PM
F1791184: D7254.id.diff
Sun, May 19, 11:11 AM
F1791144: D7254.id24392.diff
Sun, May 19, 10:34 AM
F1791108: D7254.id24484.diff
Sun, May 19, 10:25 AM
F1791056: D7254.id24591.diff
Sun, May 19, 9:57 AM
Unknown Object (File)
Sat, May 18, 3:51 AM
Unknown Object (File)
Thu, May 16, 3:30 AM
Unknown Object (File)
Wed, May 8, 11:57 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
marcin
kamil
ashoat
Commits
rCOMM00216c7f4d7f: [native] Cache decrypted media
Summary

This diff integrates media cache into app logic.

Depends on D7252, D7228

Test Plan

Sent some encrypted messages, then wiped state. Reopened the app - media are loading slowly. Exit and re-enter thread. The media should be displayed almost immediately

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Mar 30 2023, 7:07 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 30 2023, 7:07 AM
bartek updated this revision to Diff 24392.Mar 30 2023, 7:09 AM

Styling fix

Harbormaster completed remote builds in B17822: Diff 24390.Mar 30 2023, 7:23 AM
Harbormaster completed remote builds in B17823: Diff 24392.Mar 30 2023, 7:25 AM
bartek published this revision for review.Mar 30 2023, 9:30 AM
bartek added inline comments.
native/data/sqlite-data-handler.js
73 ↗(On Diff #24392)

I had no better idea where to put this. @kamil suggested that I can use this place but it looks like very SQLite specific

ashoat mentioned this in D7251: [native][lib] Introduce media cache context.Mar 30 2023, 4:37 PM
ashoat accepted this revision.Mar 30 2023, 4:40 PM
ashoat added inline comments.
native/data/sqlite-data-handler.js
73 ↗(On Diff #24392)

I think this is a good option

native/media/video-playback-modal.react.js
113 ↗(On Diff #24392)

Shorthand

This revision is now accepted and ready to land.Mar 30 2023, 4:40 PM
bartek updated this revision to Diff 24484.Mar 31 2023, 4:03 AM

Rebase, address feedback. Minor fix on video disposal when unmounted

Harbormaster completed remote builds in B17874: Diff 24484.Mar 31 2023, 4:18 AM
bartek updated this revision to Diff 24591.Apr 4 2023, 1:13 AM

As a result of discussion in D7251, added a call to mediaCacheContext.evictCache() before merging sqlite data.

Harbormaster completed remote builds in B17955: Diff 24591.Apr 4 2023, 1:29 AM
ashoat added inline comments.Apr 4 2023, 6:39 AM
native/data/sqlite-data-handler.js
149–150 ↗(On Diff #24591)

Do these really need to be awaited in sequence?

bartek updated this revision to Diff 24708.Apr 6 2023, 5:45 AM

Run promises in parallel

Harbormaster completed remote builds in B18035: Diff 24708.Apr 6 2023, 6:02 AM
Closed by commit rCOMM00216c7f4d7f: [native] Cache decrypted media (authored by bartek). · Explain WhyApr 6 2023, 6:13 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM00216c7f4d7f: [native] Cache decrypted media.

Revision Contents
Changeset List

Diff 24717

View Options

native/data/sqlite-data-handler.js

Loading...
View Options

native/media/encrypted-image.react.js

Loading...
View Options

native/media/video-playback-modal.react.js

Loading...
View Options

native/root.react.js

Loading...