Page MenuHomePhabricator

[native] Explicitly pass `NULL` to `Thread` initializer in `createThreadStoreOperations`
AbandonedPublic

Authored by atul on Apr 6 2023, 8:30 AM.
Tags
None
Referenced Files
F3357613: D7331.diff
Sun, Nov 24, 12:38 AM
Unknown Object (File)
Fri, Nov 8, 9:58 AM
Unknown Object (File)
Fri, Nov 8, 3:12 AM
Unknown Object (File)
Thu, Nov 7, 10:53 PM
Unknown Object (File)
Tue, Nov 5, 2:29 AM
Unknown Object (File)
Mon, Oct 28, 6:39 AM
Unknown Object (File)
Fri, Oct 25, 7:06 PM
Unknown Object (File)
Sep 28 2024, 8:02 AM
Subscribers

Details

Reviewers
ashoat
ginsu
rohan
Summary

avatar field of Thread struct was previously implicitly NULL. However, @rohan is adding another field to the struct after avatar positionally which means we need to set avatar to NULL for now.

This is mostly to unblock @rohan, avatar construction from jsi::Object will be implemented correctly later in my stack.

Test Plan

Builds and runs. On call with @rohan things seemed to work as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage