[lib] generate message store ops for threads on reaction failure
ClosedPublic
Actions

Authored by kamil on Apr 13 2023, 1:13 AM.

Details

Reviewers

tomek
marcin

Commits

Summary

This code generates operations need for updating threads part of message store after sendReactionMessageActionTypes.failed

Depends on D7410

Test Plan

Kill keyserver and try to react

Repository

rCOMM Comm

Branch

ops-for-ms

Lint

No Lint Coverage

Unit

No Test Coverage

kamil held this revision as a draft.

rebase

kamil published this revision for review.Apr 13 2023, 8:26 AM

tomek requested changes to this revision.Apr 14 2023, 5:56 AM

tomek added inline comments.

lib/reducers/message-reducer.js
1130–1135 ↗	(On Diff #25104)	If I remember correctly, we're not persisting `messageIDs` of threads. Is it going to change?

This revision now requires changes to proceed.Apr 14 2023, 5:56 AM

kamil requested review of this revision.Apr 18 2023, 5:52 AM

kamil added inline comments.

lib/reducers/message-reducer.js
1130–1135 ↗	(On Diff #25104)	operations are not only for database - entire logic should be based on operations (updating in-memory redux state), that's why we generate operations also for updating `messageIDs`. And then, we will convert those to database ops by excluding `messageIDs` that will not be persisted.