Page MenuHomePhabricator
Differential D7451

[native] Add CommUtilsModule boilerplate
ClosedPublic
Actions

Authored by bartek on Apr 14 2023, 5:32 AM.
Tags
None
Referenced Files
F3401688: D7451.id25162.diff
Mon, Dec 2, 1:24 PM
Unknown Object (File)
Sun, Dec 1, 1:18 AM
Unknown Object (File)
Fri, Nov 8, 8:35 AM
Unknown Object (File)
Tue, Nov 5, 4:27 AM
Unknown Object (File)
Oct 31 2024, 12:06 PM
Unknown Object (File)
Oct 28 2024, 2:58 PM
Unknown Object (File)
Oct 23 2024, 6:58 AM
Unknown Object (File)
Oct 1 2024, 1:02 PM
View All 93 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
marcin
kamil
Commits
rCOMM55262133cf58: [native] Add CommUtilsModule boilerplate
Summary

Added boilerplate implementation for CommUtilsModule introduced in parent diffs.

Depends on D7450

Test Plan

Native project compiles on both platforms. It will be tested more in the child diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Apr 14 2023, 5:32 AM
bartek held this revision as a draft.
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 14 2023, 5:32 AM
bartek added a child revision: D7452: [native] Install CommUtils JSI module.Apr 14 2023, 5:36 AM
Harbormaster failed remote builds in B18368: Diff 25162!Apr 14 2023, 5:51 AM
bartek updated this revision to Diff 25164.Apr 14 2023, 5:57 AM

Fix dummy return value for jsi::String

Harbormaster completed remote builds in B18370: Diff 25164.Apr 14 2023, 6:15 AM
bartek published this revision for review.Apr 14 2023, 8:00 AM
marcin accepted this revision.Apr 17 2023, 8:10 AM
This revision is now accepted and ready to land.Apr 17 2023, 8:10 AM
bartek updated this revision to Diff 25477.Apr 21 2023, 12:40 AM

Rebase before landing

Harbormaster completed remote builds in B18600: Diff 25477.Apr 21 2023, 12:58 AM
Closed by commit rCOMM55262133cf58: [native] Add CommUtilsModule boilerplate (authored by bartek). · Explain WhyApr 21 2023, 2:20 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM55262133cf58: [native] Add CommUtilsModule boilerplate.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
2 lines
30 lines
31 lines
ios/
Comm.xcodeproj/
6 lines

Diff 25162

View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommUtilsModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommUtilsModule.cpp

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...