Use "outline" variant of emote-smile in Edit*Avatar action sheet for visual consistency w/ image icon. This icon only appears on Android.
This is a subjective change, will just abandon if there's disagreement.
Depends on D7498
Paths
| Differential D7499 Authored by atul on Apr 18 2023, 12:46 PM.
Details Summary Use "outline" variant of emote-smile in Edit*Avatar action sheet for visual consistency w/ image icon. This icon only appears on Android. This is a subjective change, will just abandon if there's disagreement. Depends on D7498 Test Plan
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptApr 18 2023, 12:46 PM2023-04-18 12:46:02 (UTC-7) This revision is now accepted and ready to land.Apr 18 2023, 12:49 PM2023-04-18 12:49:24 (UTC-7) Harbormaster completed remote builds in B18473: Diff 25299.Apr 18 2023, 1:03 PM2023-04-18 13:03:16 (UTC-7) atul edited the summary of this revision. (Show Details)Apr 18 2023, 1:08 PM2023-04-18 13:08:51 (UTC-7) atul added a parent revision: D7498: [native] Pull `useSelectAndUploadFromGallery` out of `Edit[User/Thread]Avatar`. Closed by commit rCOMM7ed76f40821b: [native] Use `outline` variant of `emote-smile` in `Edit*Avatar` for consistency (authored by atul). · Explain WhyApr 18 2023, 1:20 PM2023-04-18 13:20:37 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 25299 native/avatars/edit-thread-avatar.react.js
native/avatars/edit-user-avatar.react.js
|