Page MenuHomePhabricator
Differential D7499

[native] Use `outline` variant of `emote-smile` in `Edit*Avatar` for consistency
ClosedPublic
Actions

Authored by atul on Apr 18 2023, 12:46 PM.
Tags
None
Referenced Files
F3179676: D7499.id25299.diff
Fri, Nov 8, 3:27 AM
F3178459: D7499.diff
Fri, Nov 8, 1:51 AM
Unknown Object (File)
Tue, Nov 5, 2:10 AM
Unknown Object (File)
Mon, Nov 4, 4:36 AM
Unknown Object (File)
Tue, Oct 15, 9:21 AM
Unknown Object (File)
Oct 3 2024, 8:30 PM
Unknown Object (File)
Oct 3 2024, 2:56 AM
Unknown Object (File)
Oct 3 2024, 2:56 AM
View All 56 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM7ed76f40821b: [native] Use `outline` variant of `emote-smile` in `Edit*Avatar` for consistency
Summary

Use "outline" variant of emote-smile in Edit*Avatar action sheet for visual consistency w/ image icon. This icon only appears on Android.

This is a subjective change, will just abandon if there's disagreement.

Depends on D7498

Test Plan

Before:

c8ad87.png (244×834 px, 26 KB)

After:

c160ca.png (270×864 px, 42 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 18 2023, 12:46 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 18 2023, 12:46 PM
atul published this revision for review.Apr 18 2023, 12:46 PM
atul edited the summary of this revision. (Show Details)
atul edited the test plan for this revision. (Show Details)
ginsu accepted this revision.Apr 18 2023, 12:49 PM

agree outline is better

This revision is now accepted and ready to land.Apr 18 2023, 12:49 PM
Harbormaster completed remote builds in B18473: Diff 25299.Apr 18 2023, 1:03 PM
atul edited the summary of this revision. (Show Details)Apr 18 2023, 1:08 PM
atul added a parent revision: D7498: [native] Pull `useSelectAndUploadFromGallery` out of `Edit[User/Thread]Avatar`.
atul added a child revision: D7502: [native] Pull `EditAvatarBadge` into its own component.
ashoat accepted this revision.Apr 18 2023, 1:14 PM
atul mentioned this in D7498: [native] Pull `useSelectAndUploadFromGallery` out of `Edit[User/Thread]Avatar`.Apr 18 2023, 1:18 PM
Closed by commit rCOMM7ed76f40821b: [native] Use `outline` variant of `emote-smile` in `Edit*Avatar` for consistency (authored by atul). · Explain WhyApr 18 2023, 1:20 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7ed76f40821b: [native] Use `outline` variant of `emote-smile` in `Edit*Avatar` for consistency.

Revision Contents
Changeset List

PathSize
native/
avatars/
9 lines
9 lines

Diff 25308

View Options

native/avatars/edit-thread-avatar.react.js

Loading...
View Options

native/avatars/edit-user-avatar.react.js

Loading...