This code generates operations needed for updating threads part of message store after message was sent with success.
Depends on D7417
Details
Details
Try to send message (with success) using different flows on both web and native
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1248 ↗ | (On Diff #25107) | |
| 1256 ↗ | (On Diff #25107) | Does it make sense to spread it here? |
| 1267–1270 ↗ | (On Diff #25107) | Shouldn't we use processedMessageStore.threads or something? |
Comment Actions
remove spread operator and rebase
| lib/reducers/message-reducer.js | ||
|---|---|---|
| 1248 ↗ | (On Diff #25107) | I don't think that's a good change, single thread is what's defined by threadID key, this object: {
...messageStore.threads[threadID],
messageIDs: newMessageIDs,
},This right here is the threads object (but I agree it will have one key). |
| 1256 ↗ | (On Diff #25107) | looks like not - thanks for pointing |
| 1267–1270 ↗ | (On Diff #25107) | same explanation as here: https://phab.comm.dev/D7398?id=25101#inline-49022 |