Page MenuHomePhabricator
Differential D7419

[lib] generate message store ops for threads after creating local message
ClosedPublic
Actions

Authored by kamil on Apr 13 2023, 7:34 AM.
Tags
None
Referenced Files
F3499460: D7419.diff
Thu, Dec 19, 11:10 PM
Unknown Object (File)
Thu, Dec 5, 1:30 AM
Unknown Object (File)
Nov 15 2024, 9:40 PM
Unknown Object (File)
Nov 15 2024, 7:12 PM
Unknown Object (File)
Nov 8 2024, 2:46 PM
Unknown Object (File)
Nov 8 2024, 2:46 PM
Unknown Object (File)
Nov 8 2024, 2:46 PM
Unknown Object (File)
Nov 8 2024, 2:46 PM
View All 87 Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
marcin
Commits
rCOMM404694cc17ab: [lib] generate message store ops for threads after creating local message
Summary

This code generates operations needed for updating threads part of message store after creating local message.

Depends on D7418

Test Plan

Try to send message some media messages nad check is there are no errors in console.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Apr 13 2023, 7:34 AM
kamil held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 13 2023, 7:34 AM
kamil added a child revision: D7420: [lib] generate message store ops for threads after pruning messages.Apr 13 2023, 7:37 AM
Harbormaster completed remote builds in B18324: Diff 25108.Apr 13 2023, 7:53 AM
kamil published this revision for review.Apr 13 2023, 8:29 AM
tomek accepted this revision.Apr 17 2023, 5:43 AM
tomek added inline comments.
lib/reducers/message-reducer.js
1523–1572 ↗(On Diff #25108)

I guess it might be simpler if updatedThreads variable wasn't created

This revision is now accepted and ready to land.Apr 17 2023, 5:43 AM
kamil updated this revision to Diff 25361.Apr 19 2023, 9:30 AM

avoid creating additional variable

lib/reducers/message-reducer.js
1523–1572 ↗(On Diff #25108)

Agree - updating

Harbormaster completed remote builds in B18516: Diff 25361.Apr 19 2023, 9:48 AM
Closed by commit rCOMM404694cc17ab: [lib] generate message store ops for threads after creating local message (authored by kamil). · Explain WhyApr 19 2023, 10:29 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM404694cc17ab: [lib] generate message store ops for threads after creating local message.

Revision Contents
Changeset List

PathSize
lib/
reducers/
32 lines

Diff 25361

View Options

lib/reducers/message-reducer.js

Loading...