Page MenuHomePhabricator
Differential D7450

[native][codegen] Generate CommUtilsModule C++ spec
ClosedPublic
Actions

Authored by bartek on Apr 14 2023, 5:29 AM.
Tags
None
Referenced Files
F3401736: D7450.diff
Mon, Dec 2, 1:40 PM
Unknown Object (File)
Tue, Nov 5, 4:27 AM
Unknown Object (File)
Tue, Nov 5, 4:27 AM
Unknown Object (File)
Tue, Nov 5, 4:27 AM
Unknown Object (File)
Oct 31 2024, 12:06 PM
Unknown Object (File)
Oct 17 2024, 9:52 PM
Unknown Object (File)
Oct 6 2024, 1:29 PM
Unknown Object (File)
Oct 6 2024, 11:06 AM
View All Files
Subscribers
• jon
tomek

Details

Reviewers
ashoat
atul
marcin
kamil
• jon
Commits
rCOMM3ef3db52e775: [native][codegen] Generate CommUtilsModule C++ spec
Summary

Modified jsi-codegen to generate C++ spec code for newly introduced CommUtilsModule.

Adding @jon because I introduced CMake change (single file -> glob)

Depends on D7449

Test Plan

Native build pass on both platforms.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Apr 14 2023, 5:29 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptApr 14 2023, 5:29 AM
bartek added a child revision: D7451: [native] Add CommUtilsModule boilerplate.Apr 14 2023, 5:32 AM
Harbormaster completed remote builds in B18367: Diff 25161.Apr 14 2023, 5:47 AM
bartek published this revision for review.Apr 14 2023, 5:47 AM
ashoat added 1 blocking reviewer(s): • jon.Apr 14 2023, 5:49 AM
ashoat added inline comments.
native/android/app/CMakeLists.txt
121 ↗(On Diff #25161)

@jon may have opinions in introducing another one of these GLOBs... I think we're trying to get rid of them generally in favor of co-located CMakeLists.txt that explicitly list out dependencies, but I don't have full context

ashoat accepted this revision.Apr 14 2023, 5:50 AM
• jon requested changes to this revision.Apr 14 2023, 6:38 AM
• jon added inline comments.
native/android/app/CMakeLists.txt
121 ↗(On Diff #25161)

My preference, as CMake doesn't handle GLOB'ing well (it doesn't know if you later add another file which fits the pattern, and will only be collected if you clean the cmake cache).

This revision now requires changes to proceed.Apr 14 2023, 6:38 AM
bartek updated this revision to Diff 25170.Apr 14 2023, 9:41 AM

Apply code review feedback

Harbormaster completed remote builds in B18373: Diff 25170.Apr 14 2023, 9:59 AM
• jon resigned from this revision.Apr 14 2023, 10:51 AM

CMake looks fine to me, defer to others for the rest

This revision is now accepted and ready to land.Apr 14 2023, 10:51 AM
bartek updated this revision to Diff 25476.Apr 21 2023, 12:40 AM

Rebase before landing

Harbormaster completed remote builds in B18599: Diff 25476.Apr 21 2023, 12:58 AM
Closed by commit rCOMM3ef3db52e775: [native][codegen] Generate CommUtilsModule C++ spec (authored by bartek). · Explain WhyApr 21 2023, 2:20 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM3ef3db52e775: [native][codegen] Generate CommUtilsModule C++ spec.

Revision Contents
Changeset List

PathSize
native/
android/
app/
5 lines
codegen/
src/
9 lines
cpp/
CommonCpp/
_generated/
ios/
Comm.xcodeproj/
6 lines

Diff 25476

View Options

native/android/app/CMakeLists.txt

Loading...
View Options

native/codegen/src/index.js

Loading...
View Options

native/cpp/CommonCpp/_generated/utilsJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/utilsJSI.h

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...