This differential adds new table to MariaDB database on the keyserver to store both primary and notifications olm accounts.
Details
Details
To test migrations-config.js restart your keyserver terminal. Ensure DB version: 32 log line is visible.
To test setup-db.js create new database and update secrets folder so that it points to new database instance. Start your keyserver.
In both cases using a database connection tool of choice (I prefer to use mariadb terminal command), ensure keyserver_olm_accounts table is present and its structure matches SQL statement used to create it.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/database/setup-db.js | ||
|---|---|---|
| 388 ↗ | (On Diff #25514) | I think this will make it unique on is_primary, but I think this is what we want |
| keyserver/src/database/setup-db.js | ||
|---|---|---|
| 388 ↗ | (On Diff #25514) | It was concluded on crypto sync that we will ever have only two olm accounts on the keyserver - one primary and one for the notifs so it was intentional. |
Comment Actions
Not clear why pickling_key and pickled_olm_account can be NULL... I think we should switch them to NOT NULL before landing
| keyserver/src/database/migration-config.js | ||
|---|---|---|
| 353–354 | Why is it possible for these to be NULL? | |
Comment Actions
Once again – please pay attention to the feedback about line length! It's not a good use of my time (or your time) to have to go back-and-forth about this. Please address it BEFORE putting up diffs in the future
| keyserver/src/database/migration-config.js | ||
|---|---|---|
| 378 ↗ | (On Diff #25998) | Continuing to see issues with line length... |