Introduce user avatar camera modal
Depends on D7676
Details
Details
- Reviewers
ashoat atul - Commits
- rCOMM6cb4138efeda: [native] introduce user avatar camera modal
Difficult to provide a demo video, but I was able to use my camera to take a photo and the photo i snapped was set as my avatar after hitting "send" in the camera modal. Also tested going back, and when I hit the "X" button it just goes back to the profile screen. I also double checked that the loading state was in sync with the edit user avatar provider
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/avatars/edit-user-avatar-provider.react.js | ||
|---|---|---|
| 105–127 ↗ | (On Diff #25711) | shoot didn't realize how much copy + paste I was doing here. Will create another diff and put it in the stack before this diff and update this diff accordingly |
| native/avatars/edit-user-avatar.react.js | ||
|---|---|---|
| 50 | Can we use UserAvatarCameraModalRouteName here instead of copy-pasting the string? And can you make sure you haven't done this anywhere else? | |
| native/media/user-avatar-camera-modal.react.js | ||
| 25–30 | This useCallback is not necessary, and is only here because you typed BaseProps in CameraModal poorly. You should be able to pass updateImageUserAvatar directly to CameraModal if you type handlePhotoCapture as (capture: PhotoCapture) => mixed. There's no reason that CameraModal needs to care about the return type there, so you should make the contract as "permissive" as possible, and let the function return anything it wants (mixed). That way it can return eg. a Promise without causing type errors. | |
| native/avatars/edit-user-avatar.react.js | ||
|---|---|---|
| 50 | Did a global search and couldn't find any other instances of this | |