[native] Calculate SHA256 of encrypted blob
ClosedPublic
Actions

Authored by bartek on Apr 27 2023, 3:53 AM.

Details

Reviewers

atul
marcin

Commits

rCOMMde360ffea5af: [native] Calculate SHA256 of encrypted blob

Summary

We need the blob hash in order to upload the encrypted blob to Blob service.
According to whitepaper, we use SHA256 to calculate the hash of encrypted blob.

Exposed the calculated SHA256 within encryption result payload.

Test Plan

Added console.log and sent encrypted video message. Verified that both video and thumbnail have blobHash field.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 27 2023, 3:53 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 27 2023, 3:53 AM

Harbormaster completed remote builds in B18841: Diff 25810.Apr 27 2023, 4:11 AM

bartek added a child revision: D7650: [native] Upload encrypted media to Blob service.Apr 27 2023, 4:29 AM

bartek published this revision for review.Apr 27 2023, 4:36 AM

bartek added inline comments.

web/media/encryption-utils.js
72	This will be set in one of the web-part stack diffs

bartek mentioned this in D7688: [web] Caclulate encrypted media sha256.Apr 29 2023, 9:16 AM

atul accepted this revision.May 3 2023, 10:45 AM

atul added inline comments.

lib/types/media-types.js
270	We need the blob hash in order to upload the encrypted blob to Blob service. Should `sha256` be `string` instead of `?string`? EDIT: Looks like we can make this `string` after `web/media/encryption-utils.js` is updated?
native/media/encryption-utils.js
110–115	Would it make sense to have a different `reason` instead of "encryption_failed" if computing `sha256` fails (not sure in what scenario this would happen)?
185–189	We could destructure these fields from `encryptionResult`, but whatever you prefer