Page MenuHomePhabricator
Differential D7858

Add initial notifications encrypted message generator to client responses selector on native
ClosedPublic
Actions

Authored by marcin on May 18 2023, 4:51 AM.
Tags
None
Referenced Files
F5082708: D7858.id27190.diff
Sat, Mar 29, 9:22 AM
Unknown Object (File)
Fri, Mar 21, 10:54 AM
Unknown Object (File)
Tue, Mar 18, 6:32 AM
Unknown Object (File)
Tue, Mar 18, 6:32 AM
Unknown Object (File)
Tue, Mar 18, 6:32 AM
Unknown Object (File)
Tue, Mar 18, 6:32 AM
Unknown Object (File)
Tue, Mar 18, 6:32 AM
Unknown Object (File)
Tue, Mar 18, 6:32 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
bartek
Commits
rCOMMbc9f1072d61f: Add initial notifications encrypted message generator to client responses…
rCOMM2517661f0b92: Add initial notifications encrypted message generator to client responses…
Summary

This differential adds initial notifications encrypted message generator to client response selector on native

Test Plan

Run flow

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-3026
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.May 18 2023, 4:51 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 18 2023, 4:51 AM
marcin added a parent revision: D7857: Introduce initial notifications encrypted message getter to socket selectors.May 18 2023, 5:03 AM
marcin added a child revision: D7859: Add method to check for missing olm sessions for notifs and use it to send relevant request.
Harbormaster completed remote builds in B19460: Diff 26625.May 18 2023, 5:09 AM
marcin requested review of this revision.May 18 2023, 5:09 AM
marcin added a parent revision: D7856: Add request and response types for the keyserver to request first encrypted message for e2e notifs.May 18 2023, 5:50 AM
marcin removed a parent revision: D7857: Introduce initial notifications encrypted message getter to socket selectors.
marcin added 1 blocking reviewer(s): atul.May 18 2023, 5:53 AM
tomek accepted this revision.May 22 2023, 2:03 AM
atul accepted this revision.May 22 2023, 9:46 AM
This revision is now accepted and ready to land.May 22 2023, 9:46 AM
marcin updated this revision to Diff 27189.May 29 2023, 11:54 AM

Rebase before landing

marcin updated this revision to Diff 27190.May 29 2023, 11:56 AM

Rebase before landing

Harbormaster completed remote builds in B19858: Diff 27189.May 29 2023, 12:52 PM
Harbormaster completed remote builds in B19859: Diff 27190.May 29 2023, 12:54 PM
Closed by commit rCOMM2517661f0b92: Add initial notifications encrypted message generator to client responses… (authored by marcin). · Explain WhyMay 29 2023, 1:41 PM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM2517661f0b92: Add initial notifications encrypted message generator to client responses….
marcin added a reverting change: rCOMM2a82628a3a00: Revert "Add initial notifications encrypted message generator to client….May 31 2023, 6:00 AM
marcin reopened this revision.May 31 2023, 8:37 AM
This revision is now accepted and ready to land.May 31 2023, 8:37 AM
marcin updated this revision to Diff 27344.Jun 1 2023, 6:09 AM

Rebase before landing

Harbormaster completed remote builds in B19954: Diff 27344.Jun 1 2023, 6:30 AM
Closed by commit rCOMMbc9f1072d61f: Add initial notifications encrypted message generator to client responses… (authored by marcin). · Explain WhyJun 1 2023, 6:55 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMbc9f1072d61f: Add initial notifications encrypted message generator to client responses….

Revision Contents
Changeset List

PathSize
native/
6 lines

Diff 26625

View Options

native/socket.react.js

Show All 25 Linesprovider "aws" {
skip_credentials_validation = local.aws_settings.skip_credentials_validation skip_credentials_validation = local.aws_settings.skip_credentials_validation
skip_metadata_api_check = local.aws_settings.skip_metadata_api_check skip_metadata_api_check = local.aws_settings.skip_metadata_api_check
skip_requesting_account_id = local.aws_settings.skip_requesting_account_id skip_requesting_account_id = local.aws_settings.skip_requesting_account_id
s3_use_path_style = local.aws_settings.s3_use_path_style s3_use_path_style = local.aws_settings.s3_use_path_style
dynamic "endpoints" { dynamic "endpoints" {
for_each = local.aws_settings.override_endpoint[*] for_each = local.aws_settings.override_endpoint[*]
content { content {
opensearch = endpoints.value
dynamodb = endpoints.value dynamodb = endpoints.value
s3 = endpoints.value s3 = endpoints.value
secretsmanager = endpoints.value secretsmanager = endpoints.value
} }
} }
} }
provider "random" {} provider "random" {}
# Shared resources between local dev environment and remote AWS # Shared resources between local dev environment and remote AWS
module "shared" { module "shared" {
source = "../modules/shared" source = "../modules/shared"
is_dev = true is_dev = true
vpc = null
} }