Page MenuHomePhabricator
Differential D7967

[native] Add `enumCell` layout/styling to `CommunityConfiguration`
ClosedPublic
Actions

Authored by atul on May 24 2023, 12:09 PM.
Tags
None
Referenced Files
F3559997: D7967.diff
Fri, Dec 27, 6:52 AM
Unknown Object (File)
Sat, Dec 21, 9:24 AM
Unknown Object (File)
Fri, Dec 20, 3:28 AM
Unknown Object (File)
Fri, Dec 20, 3:28 AM
Unknown Object (File)
Fri, Dec 20, 3:28 AM
Unknown Object (File)
Fri, Dec 20, 3:26 AM
Unknown Object (File)
Fri, Dec 20, 3:01 AM
Unknown Object (File)
Sun, Dec 8, 6:48 PM
View All Files
Subscribers
• ted
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMdf85a4fbd4b5: [native] Add `enumCell` layout/styling to `CommunityConfiguration`
Summary

We want something similar to EnumSettingsOption on web for native so we can use it in CommunityConfiguration to match designs: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?type=design&node-id=11731-270974&t=FY25j6NZvAs5ly4w-4

For now we're just laying things out, the checkbox is not functional. Checkbox will be made functional in next diff. Will also probably pull out some sort of EnumSettingsOption equivalent for native.

Test Plan

Looks as expected:

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-05-24 at 15.05.38.png (2×1 px, 137 KB)

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-05-24 at 15.05.25.png (2×1 px, 138 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.May 24 2023, 12:09 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 24 2023, 12:09 PM
atul edited the test plan for this revision. (Show Details)May 24 2023, 12:13 PM
atul published this revision for review.May 24 2023, 12:18 PM
atul added a subscriber: • ted.
atul added inline comments.
native/community-creation/community-configuration.react.js
173 ↗(On Diff #27013)

This doesn't look great in light mode (not enough contrast IMO), would be good to get @ted's feedback on this when he's back

Harbormaster completed remote builds in B19753: Diff 27013.May 24 2023, 12:27 PM
atul added inline comments.May 24 2023, 12:28 PM
native/community-creation/community-configuration.react.js
173 ↗(On Diff #27013)

Left a comment here so it's tracked: https://linear.app/comm/issue/DES-89/ensure-consistent-forminput-styling-throughout-designs#comment-373efbc1

atul added a child revision: D7968: [native] Make `enumCheckBox` functional in `CommunityConfiguration`.May 24 2023, 1:01 PM
ashoat accepted this revision.May 24 2023, 4:08 PM
This revision is now accepted and ready to land.May 24 2023, 4:08 PM
atul updated this revision to Diff 27046.May 25 2023, 4:38 AM

rebase and land

Harbormaster completed remote builds in B19763: Diff 27046.May 25 2023, 4:56 AM
Closed by commit rCOMMdf85a4fbd4b5: [native] Add `enumCell` layout/styling to `CommunityConfiguration` (authored by atul). · Explain WhyMay 25 2023, 5:15 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMdf85a4fbd4b5: [native] Add `enumCell` layout/styling to `CommunityConfiguration`.

Revision Contents
Changeset List

PathSize
native/
community-creation/
53 lines

Diff 27051

View Options

native/community-creation/community-configuration.react.js

Loading...