Page MenuHomePhabricator
Differential D8017

[native] Replace setENSUserAvatar and removeUserAvatar with generic setUserAvatar
ClosedPublic
Actions

Authored by ashoat on May 29 2023, 5:34 PM.
Tags
None
Referenced Files
F3445016: D8017.diff
Tue, Dec 10, 11:27 PM
Unknown Object (File)
Wed, Dec 4, 2:13 AM
Unknown Object (File)
Wed, Dec 4, 2:09 AM
Unknown Object (File)
Wed, Dec 4, 1:24 AM
Unknown Object (File)
Thu, Nov 28, 7:46 PM
Unknown Object (File)
Nov 10 2024, 1:59 PM
Unknown Object (File)
Oct 31 2024, 5:13 PM
Unknown Object (File)
Oct 27 2024, 8:19 AM
View All 75 Files
Subscribers
tomek

Details

Reviewers
ginsu
atul
Commits
rCOMM4767be3e48bf: [native] Replace setENSUserAvatar and removeUserAvatar with generic…
Summary

I have two goals here:

  1. Simplify the code
  2. Open a generic pathway for EmojiUserAvatarCreation to use the EditUserAvatarProvider, so that every place is going through it. I want to unify all pathways through EditUserAvatarProvider so I can override what happens when an avatar is selected, so that I can maximize code reuse in the registration flow
Test Plan

Test clearing user avatar via iOS simulator

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.May 29 2023, 5:34 PM
Herald added a subscriber: tomek. · View Herald TranscriptMay 29 2023, 5:34 PM
ashoat added a child revision: D8018: [native] Replace generic useSaveUserAvatar with new generic setUserAvatar.May 29 2023, 5:34 PM
ashoat mentioned this in D8020: [native] Replace removeThreadAvatar with generic setThreadAvatar.May 29 2023, 5:39 PM
Harbormaster completed remote builds in B19877: Diff 27233.May 29 2023, 5:52 PM
ashoat requested review of this revision.May 29 2023, 5:52 PM
ashoat updated this revision to Diff 27261.May 30 2023, 5:51 AM

Make setUserAvatar return Promise<void> so that it can be used in the registration flow with the expectation that it calls the keyserver

Harbormaster completed remote builds in B19900: Diff 27261.May 30 2023, 6:09 AM
atul accepted this revision.May 30 2023, 9:12 AM
This revision is now accepted and ready to land.May 30 2023, 9:12 AM
Closed by commit rCOMM4767be3e48bf: [native] Replace setENSUserAvatar and removeUserAvatar with generic… (authored by ashoat). · Explain WhyMay 30 2023, 12:09 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM4767be3e48bf: [native] Replace setENSUserAvatar and removeUserAvatar with generic….
ashoat mentioned this in rCOMMf5969fd86183: [native] Replace removeThreadAvatar with generic setThreadAvatar.
ashoat mentioned this in D8041: [native] Introduce RegistrationMode in EditUserAvatarProvider.May 31 2023, 1:27 PM

Revision Contents
Changeset List

Diff 27233

View Options

native/avatars/edit-user-avatar-provider.react.js

Loading...
View Options

native/avatars/edit-user-avatar.react.js

Loading...