[Identity] Refactor access token verification to be more usable
ClosedPublic
Actions

Authored by • jon on Jun 5 2023, 7:34 AM.

Details

Reviewers

varun
bartek

Commits

rCOMM5d9862b54918: [Identity] Refactor access token verification to be more usable

Summary

Verifying if an access token is valid will be a common
action with many of the API calls. We should make this as ergonomic
as possible.

Part of https://linear.app/comm/issue/ENG-3943

Test Plan

Set up identity service and localstack

nix develop

(cd services/identity && RUST_LOG=debug cargo run -- server)
(cd services/commtest && cargo test --test identity_access_tokens_tests)

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/refresh-keys

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jun 5 2023, 7:34 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 5 2023, 7:34 AM

Allow test to run multiple times without failing

Harbormaster completed remote builds in B20023: Diff 27443.Jun 5 2023, 1:51 PM

Harbormaster completed remote builds in B20024: Diff 27444.

• jon requested review of this revision.Jun 5 2023, 1:53 PM

bartek accepted this revision.Jun 5 2023, 10:01 PM

This revision is now accepted and ready to land.Jun 5 2023, 10:01 PM

• jon added a child revision: D8126: [Protos] Update uploadOneTimeKeys to include device info and both sets of keys.Jun 6 2023, 10:39 AM

• jon added 1 blocking reviewer(s): varun.Jun 6 2023, 10:43 AM

This revision now requires review to proceed.Jun 6 2023, 10:43 AM

varun accepted this revision.Jun 6 2023, 11:54 AM

varun added inline comments.

services/commtest/tests/identity_access_tokens_tests.rs
28 ↗	(On Diff #27444)	might be worth adding a comment above this line explaining that the device ID is the primary ed25519 public key from the above payload

This revision is now accepted and ready to land.Jun 6 2023, 11:54 AM

Address feedback

Harbormaster completed remote builds in B20123: Diff 27570.Jun 8 2023, 5:32 PM

Closed by commit rCOMM5d9862b54918: [Identity] Refactor access token verification to be more usable (authored by • jon). · Explain WhyJun 11 2023, 8:03 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM5d9862b54918: [Identity] Refactor access token verification to be more usable.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

20 lines

database.rs

21 lines

Diff 27443

View Options

services/identity/src/client_service.rs