[native] Create a ChangeRolesHeaderLeftButton to cancel role changes
ClosedPublic
Actions

Authored by rohan on Jun 9 2023, 11:29 AM.

Details

Reviewers

atul
ginsu
tomek

Commits

rCOMM6f5fbe01189d: [native] Create a ChangeRolesHeaderLeftButton to cancel role changes

Summary

Per the designs, we want the button on the top left of the screen to be 'Cancel'. This diff introduces the headerLeft component.

I followed some of the work for the invite links modal on native to get the types correct for creating a separate component for headerLeft and headerRight (later in the stack), so also adding @tomek as a non-blocking reviewer for these 3 diffs

Depends on D8157

Test Plan

Confirm that the 'Cancel' button appears on the top left of the header and closes the screen

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Jun 9 2023, 11:29 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 9 2023, 11:29 AM

rohan edited the summary of this revision. (Show Details)Jun 9 2023, 11:33 AM

rohan edited the test plan for this revision. (Show Details)

rohan attached a referenced file: F580217: Simulator Screen Recording - iPhone 14 Pro - 2023-06-09 at 14.30.08.mp4. (Show Details)

rohan added a reviewer: tomek.

rohan added a child revision: D8159: [native] Handle unsaved changes when 'cancel' is pressed.Jun 9 2023, 11:36 AM

rohan edited the summary of this revision. (Show Details)Jun 9 2023, 11:50 AM

Harbormaster completed remote builds in B20137: Diff 27587.Jun 9 2023, 11:51 AM

rohan requested review of this revision.Jun 9 2023, 11:51 AM

atul accepted this revision.Jun 12 2023, 1:10 PM

atul added inline comments.

native/roles/change-roles-header-left-button.react.js
11 ↗	(On Diff #27587)	Could we just call this `LeftHeaderCancelButton` or something along those lines to make it more "general purpose" since there isn't anything "ChangeRoles" specific about this component?