Page MenuHomePhabricator
Differential D8656

[native] generate C++ spec for CommRustModule
ClosedPublic
Actions

Authored by kamil on Jul 28 2023, 9:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 3:18 PM
Unknown Object (File)
Tue, Apr 22, 6:10 AM
Unknown Object (File)
Tue, Apr 22, 5:39 AM
Unknown Object (File)
Tue, Apr 22, 12:08 AM
Unknown Object (File)
Mon, Apr 21, 9:28 PM
Unknown Object (File)
Sun, Apr 20, 11:02 PM
Unknown Object (File)
Sat, Apr 19, 12:51 AM
Unknown Object (File)
Wed, Apr 9, 1:06 AM
View All Files
Subscribers
ashoat

Details

Reviewers
bartek
michal
tomek
varun
Commits
rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule
Summary

ENG-4232

Creating a separate module for Rust API. This is a part of CommCoreModule refactor.

Make codegen generate C++ for module.

Depends on D8655

Test Plan

run codegen-jsi

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 28 2023, 9:47 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 28 2023, 9:47 AM
kamil added a child revision: D8657: [native] add CommRustModule implementation.Jul 28 2023, 9:54 AM
Harbormaster failed remote builds in B21308: Diff 29184!Jul 28 2023, 10:10 AM
kamil published this revision for review.Jul 28 2023, 10:20 AM
bartek accepted this revision.Jul 31 2023, 2:46 AM
This revision is now accepted and ready to land.Jul 31 2023, 2:46 AM
kamil updated this revision to Diff 29288.Jul 31 2023, 8:50 AM

rebase

Harbormaster failed remote builds in B21376: Diff 29288!Jul 31 2023, 9:56 AM
kamil updated this revision to Diff 29296.Jul 31 2023, 10:05 AM

fix dependencies (I messed up while resolving conflicts)

Harbormaster completed remote builds in B21384: Diff 29296.Jul 31 2023, 11:44 AM
Closed by commit rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule (authored by kamil). · Explain WhyAug 1 2023, 2:17 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM7d6853161f4e: [native] generate C++ spec for CommRustModule.

Revision Contents
Changeset List

PathSize
native/
android/
app/
1 line
codegen/
src/
4 lines
cpp/
CommonCpp/
_generated/
ios/
Comm.xcodeproj/
6 lines

Diff 29184

View Options

native/android/app/CMakeLists.txt

package app.comm.android; package app.comm.android;
import android.content.Context; import android.content.Context;
import android.content.res.Configuration; import android.content.res.Configuration;
import android.database.CursorWindow; import android.database.CursorWindow;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.multidex.MultiDexApplication; import androidx.multidex.MultiDexApplication;
import app.comm.android.commservices.CommServicesPackage; import app.comm.android.commservices.CommServicesPackage;
import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore; import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.DatabaseInitializer; import app.comm.android.fbjni.DatabaseInitializer;
import app.comm.android.fbjni.GlobalDBSingleton; import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.newarchitecture.MainApplicationReactNativeHost; import app.comm.android.newarchitecture.MainApplicationReactNativeHost;
import app.comm.android.notifications.CommAndroidNotificationsPackage; import app.comm.android.notifications.CommAndroidNotificationsPackage;
import com.facebook.react.PackageList; import com.facebook.react.PackageList;
import com.facebook.react.ReactApplication; import com.facebook.react.ReactApplication;
import com.facebook.react.ReactInstanceManager; import com.facebook.react.ReactInstanceManager;
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines public void onCreate() {
// system // system
MainApplication.context = this.getApplicationContext(); MainApplication.context = this.getApplicationContext();
ReactFeatureFlags.useTurboModules = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED; ReactFeatureFlags.useTurboModules = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED;
Security.insertProviderAt(new org.conscrypt.OpenSSLProvider(), 1); Security.insertProviderAt(new org.conscrypt.OpenSSLProvider(), 1);
SoLoader.init(this, /* native exopackage */ false); SoLoader.init(this, /* native exopackage */ false);
this.initializeDatabase(); this.initializeDatabase();
CommMMKV.initialize();
ApplicationLifecycleDispatcher.onApplicationCreate(this); ApplicationLifecycleDispatcher.onApplicationCreate(this);
try { try {
Field field = CursorWindow.class.getDeclaredField("sCursorWindowSize"); Field field = CursorWindow.class.getDeclaredField("sCursorWindowSize");
field.setAccessible(true); field.setAccessible(true);
field.set(null, 100 * 1024 * 1024); // 100 MiB field.set(null, 100 * 1024 * 1024); // 100 MiB
} catch (Exception e) { } catch (Exception e) {
if (BuildConfig.DEBUG) { if (BuildConfig.DEBUG) {
e.printStackTrace(); e.printStackTrace();
Show All 25 Lines
View Options

native/codegen/src/index.js

package app.comm.android; package app.comm.android;
import android.content.Context; import android.content.Context;
import android.content.res.Configuration; import android.content.res.Configuration;
import android.database.CursorWindow; import android.database.CursorWindow;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.multidex.MultiDexApplication; import androidx.multidex.MultiDexApplication;
import app.comm.android.commservices.CommServicesPackage; import app.comm.android.commservices.CommServicesPackage;
import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore; import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.DatabaseInitializer; import app.comm.android.fbjni.DatabaseInitializer;
import app.comm.android.fbjni.GlobalDBSingleton; import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.newarchitecture.MainApplicationReactNativeHost; import app.comm.android.newarchitecture.MainApplicationReactNativeHost;
import app.comm.android.notifications.CommAndroidNotificationsPackage; import app.comm.android.notifications.CommAndroidNotificationsPackage;
import com.facebook.react.PackageList; import com.facebook.react.PackageList;
import com.facebook.react.ReactApplication; import com.facebook.react.ReactApplication;
import com.facebook.react.ReactInstanceManager; import com.facebook.react.ReactInstanceManager;
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines public void onCreate() {
// system // system
MainApplication.context = this.getApplicationContext(); MainApplication.context = this.getApplicationContext();
ReactFeatureFlags.useTurboModules = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED; ReactFeatureFlags.useTurboModules = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED;
Security.insertProviderAt(new org.conscrypt.OpenSSLProvider(), 1); Security.insertProviderAt(new org.conscrypt.OpenSSLProvider(), 1);
SoLoader.init(this, /* native exopackage */ false); SoLoader.init(this, /* native exopackage */ false);
this.initializeDatabase(); this.initializeDatabase();
CommMMKV.initialize();
ApplicationLifecycleDispatcher.onApplicationCreate(this); ApplicationLifecycleDispatcher.onApplicationCreate(this);
try { try {
Field field = CursorWindow.class.getDeclaredField("sCursorWindowSize"); Field field = CursorWindow.class.getDeclaredField("sCursorWindowSize");
field.setAccessible(true); field.setAccessible(true);
field.set(null, 100 * 1024 * 1024); // 100 MiB field.set(null, 100 * 1024 * 1024); // 100 MiB
} catch (Exception e) { } catch (Exception e) {
if (BuildConfig.DEBUG) { if (BuildConfig.DEBUG) {
e.printStackTrace(); e.printStackTrace();
Show All 25 Lines
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

package app.comm.android; package app.comm.android;
import android.content.Context; import android.content.Context;
import android.content.res.Configuration; import android.content.res.Configuration;
import android.database.CursorWindow; import android.database.CursorWindow;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.multidex.MultiDexApplication; import androidx.multidex.MultiDexApplication;
import app.comm.android.commservices.CommServicesPackage; import app.comm.android.commservices.CommServicesPackage;
import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore; import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.DatabaseInitializer; import app.comm.android.fbjni.DatabaseInitializer;
import app.comm.android.fbjni.GlobalDBSingleton; import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.newarchitecture.MainApplicationReactNativeHost; import app.comm.android.newarchitecture.MainApplicationReactNativeHost;
import app.comm.android.notifications.CommAndroidNotificationsPackage; import app.comm.android.notifications.CommAndroidNotificationsPackage;
import com.facebook.react.PackageList; import com.facebook.react.PackageList;
import com.facebook.react.ReactApplication; import com.facebook.react.ReactApplication;
import com.facebook.react.ReactInstanceManager; import com.facebook.react.ReactInstanceManager;
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines public void onCreate() {
// system // system
MainApplication.context = this.getApplicationContext(); MainApplication.context = this.getApplicationContext();
ReactFeatureFlags.useTurboModules = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED; ReactFeatureFlags.useTurboModules = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED;
Security.insertProviderAt(new org.conscrypt.OpenSSLProvider(), 1); Security.insertProviderAt(new org.conscrypt.OpenSSLProvider(), 1);
SoLoader.init(this, /* native exopackage */ false); SoLoader.init(this, /* native exopackage */ false);
this.initializeDatabase(); this.initializeDatabase();
CommMMKV.initialize();
ApplicationLifecycleDispatcher.onApplicationCreate(this); ApplicationLifecycleDispatcher.onApplicationCreate(this);
try { try {
Field field = CursorWindow.class.getDeclaredField("sCursorWindowSize"); Field field = CursorWindow.class.getDeclaredField("sCursorWindowSize");
field.setAccessible(true); field.setAccessible(true);
field.set(null, 100 * 1024 * 1024); // 100 MiB field.set(null, 100 * 1024 * 1024); // 100 MiB
} catch (Exception e) { } catch (Exception e) {
if (BuildConfig.DEBUG) { if (BuildConfig.DEBUG) {
e.printStackTrace(); e.printStackTrace();
Show All 25 Lines
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

package app.comm.android; package app.comm.android;
import android.content.Context; import android.content.Context;
import android.content.res.Configuration; import android.content.res.Configuration;
import android.database.CursorWindow; import android.database.CursorWindow;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
import androidx.multidex.MultiDexApplication; import androidx.multidex.MultiDexApplication;
import app.comm.android.commservices.CommServicesPackage; import app.comm.android.commservices.CommServicesPackage;
import app.comm.android.fbjni.CommMMKV;
import app.comm.android.fbjni.CommSecureStore; import app.comm.android.fbjni.CommSecureStore;
import app.comm.android.fbjni.DatabaseInitializer; import app.comm.android.fbjni.DatabaseInitializer;
import app.comm.android.fbjni.GlobalDBSingleton; import app.comm.android.fbjni.GlobalDBSingleton;
import app.comm.android.newarchitecture.MainApplicationReactNativeHost; import app.comm.android.newarchitecture.MainApplicationReactNativeHost;
import app.comm.android.notifications.CommAndroidNotificationsPackage; import app.comm.android.notifications.CommAndroidNotificationsPackage;
import com.facebook.react.PackageList; import com.facebook.react.PackageList;
import com.facebook.react.ReactApplication; import com.facebook.react.ReactApplication;
import com.facebook.react.ReactInstanceManager; import com.facebook.react.ReactInstanceManager;
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines public void onCreate() {
// system // system
MainApplication.context = this.getApplicationContext(); MainApplication.context = this.getApplicationContext();
ReactFeatureFlags.useTurboModules = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED; ReactFeatureFlags.useTurboModules = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED;
Security.insertProviderAt(new org.conscrypt.OpenSSLProvider(), 1); Security.insertProviderAt(new org.conscrypt.OpenSSLProvider(), 1);
SoLoader.init(this, /* native exopackage */ false); SoLoader.init(this, /* native exopackage */ false);
this.initializeDatabase(); this.initializeDatabase();
CommMMKV.initialize();
ApplicationLifecycleDispatcher.onApplicationCreate(this); ApplicationLifecycleDispatcher.onApplicationCreate(this);
try { try {
Field field = CursorWindow.class.getDeclaredField("sCursorWindowSize"); Field field = CursorWindow.class.getDeclaredField("sCursorWindowSize");
field.setAccessible(true); field.setAccessible(true);
field.set(null, 100 * 1024 * 1024); // 100 MiB field.set(null, 100 * 1024 * 1024); // 100 MiB
} catch (Exception e) { } catch (Exception e) {
if (BuildConfig.DEBUG) { if (BuildConfig.DEBUG) {
e.printStackTrace(); e.printStackTrace();
Show All 25 Lines
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...