Page MenuHomePhabricator
Differential D8659

[CommCoreModule] implement C++ ThreadStore
ClosedPublic
Actions

Authored by kamil on Jul 28 2023, 10:55 AM.
Tags
None
Referenced Files
F3367537: D8659.id.diff
Mon, Nov 25, 3:00 PM
Unknown Object (File)
Sat, Nov 23, 2:37 PM
Unknown Object (File)
Sat, Nov 23, 12:54 PM
Unknown Object (File)
Sat, Nov 23, 9:56 AM
Unknown Object (File)
Sat, Nov 23, 9:56 AM
Unknown Object (File)
Thu, Nov 7, 5:28 AM
Unknown Object (File)
Tue, Nov 5, 7:54 AM
Unknown Object (File)
Tue, Nov 5, 7:54 AM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
• jon
atul
tomek
Commits
rCOMMef04728fafd8: [CommCoreModule] implement C++ ThreadStore
Summary

Grouping logic in one class to make it cleaner and reuse some code.

Depends on: D8604

Test Plan

Build iOS and Android and play with threads to make sure functionality still works.

Diff Detail

Repository
rCOMM Comm
Branch
core-module-refactor
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 28 2023, 10:55 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 28 2023, 10:56 AM
kamil updated this revision to Diff 29189.Jul 28 2023, 11:07 AM

fix commit

kamil added a parent revision: D8604: [CommCoreModule] implement C++ DraftStore.Jul 28 2023, 11:08 AM
Harbormaster failed remote builds in B21311: Diff 29188!Jul 28 2023, 11:33 AM
Harbormaster failed remote builds in B21312: Diff 29189!Jul 28 2023, 11:35 AM
kamil added a child revision: D8662: [CommCoreModule] implement C++ MessageStore.Jul 29 2023, 2:51 AM
kamil published this revision for review.Jul 31 2023, 1:29 AM
tomek accepted this revision.Jul 31 2023, 3:23 AM
This revision is now accepted and ready to land.Jul 31 2023, 3:23 AM
kamil updated this revision to Diff 29268.Jul 31 2023, 6:21 AM

rebase

This revision was landed with ongoing or failed builds.Jul 31 2023, 8:03 AM
Closed by commit rCOMMef04728fafd8: [CommCoreModule] implement C++ ThreadStore (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMef04728fafd8: [CommCoreModule] implement C++ ThreadStore.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
2 lines
2 lines
250 lines
PersistentStorageUtilities/
DataStores/
30 lines
200 lines
ios/
Comm.xcodeproj/
6 lines

Diff 29189

View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadStore.cpp

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...