Paths

Table of Contentst

Differential D8604

[CommCoreModule] implement C++ DraftStore
ClosedPublic
Actions

Authored by kamil on Jul 24 2023, 1:06 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

michal
• jon
atul
tomek
marcin

Commits

rCOMMe3069eac7e0d: [CommCoreModule] implement C++ DraftStore

Summary

Grouping logic in one class to make it cleaner and reuse some code.

NOTE: I will wait with creating diffs for the rest of the stores until this is accepted because rest will be very similar to this one.

Depends on: D8603

Test Plan

Build iOS and Android and play with drafts to make sure functionality still works.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 24 2023, 1:06 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 24 2023, 1:06 PM

kamil added a parent revision: D8603: [CommCoreModule] introduce BaseDataStore template class.Jul 24 2023, 1:07 PM

Harbormaster completed remote builds in B21140: Diff 28962.Jul 24 2023, 1:24 PM

kamil published this revision for review.Jul 24 2023, 1:25 PM

Would be good to get signoff from @tomek or @marcin before landing

This revision is now accepted and ready to land.Jul 25 2023, 6:10 AM

In D8604#253487, @atul wrote:

Would be good to get signoff from @tomek or @marcin before landing

Thanks @atul

This revision now requires review to proceed.Jul 25 2023, 8:52 AM

michal accepted this revision.Jul 25 2023, 9:18 AM

tomek accepted this revision.Jul 25 2023, 10:17 AM

tomek added inline comments.

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/DraftStore.cpp
14–17 ↗	(On Diff #28962)	Why do we need these?

This revision is now accepted and ready to land.Jul 25 2023, 10:17 AM

kamil mentioned this in D8659: [CommCoreModule] implement C++ ThreadStore.Jul 28 2023, 5:56 PM

kamil added a child revision: D8659: [CommCoreModule] implement C++ ThreadStore.Jul 28 2023, 6:08 PM

kamil added inline comments.Jul 31 2023, 1:12 PM

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/DraftStore.cpp
14–17 ↗	(On Diff #28962)	Thanks for pointing this out. The constructor will be updated because we want to pass `std::shared_ptr<facebook::react::CallInvoker> jsInvoker` via constructor. The default destructor is not needed because is not doing anything and this class is not virtual.

rebase

Harbormaster completed remote builds in B21363: Diff 29267.Jul 31 2023, 1:43 PM

Closed by commit rCOMMe3069eac7e0d: [CommCoreModule] implement C++ DraftStore. · Explain WhyJul 31 2023, 3:03 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMe3069eac7e0d: [CommCoreModule] implement C++ DraftStore.

kamil mentioned this in rCOMMef04728fafd8: [CommCoreModule] implement C++ ThreadStore.

kamil mentioned this in D8681: [native] remove unused `using namespace`.Jul 31 2023, 5:01 PM

kamil mentioned this in rCOMM20127c72f417: [native] remove unused `using namespace`.Aug 1 2023, 12:43 PM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

5 lines

CommCoreModule.h

2 lines

CommCoreModule.cpp

103 lines

DraftStoreOperations.h

6 lines

PersistentStorageUtilities/

DataStores/

BaseDataStore.h

2 lines

29 lines

67 lines

ios/

Comm.xcodeproj/

project.pbxproj

6 lines

Diff 29283

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/NativeModules/DraftStoreOperations.h

Loading...

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/BaseDataStore.h

Loading...

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/DraftStore.h

Loading...

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/DraftStore.cpp

Loading...

native/ios/Comm.xcodeproj/project.pbxproj

Loading...