[CommCoreModule] implement C++ ReportStore
ClosedPublic
Actions

Authored by kamil on Jul 29 2023, 10:07 AM.

Details

Reviewers

michal
• jon
atul
tomek

Commits

rCOMMe58543880d96: [CommCoreModule] implement C++ ReportStore

Summary

Grouping logic in one class to make it cleaner and reuse some code.

Depends on D8662

Test Plan

Build iOS and Android and play with reports to make sure functionality still works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 29 2023, 10:07 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 29 2023, 10:07 AM

kamil added a child revision: D8664: [CommCoreModule] remove unused includes.Jul 29 2023, 10:14 AM

Harbormaster completed remote builds in B21334: Diff 29225.Jul 29 2023, 10:25 AM

kamil published this revision for review.Jul 31 2023, 8:31 AM

tomek accepted this revision.Jul 31 2023, 10:52 AM

This revision is now accepted and ready to land.Jul 31 2023, 10:52 AM

rebase

Harbormaster completed remote builds in B21366: Diff 29270.Jul 31 2023, 2:22 PM

Closed by commit rCOMMe58543880d96: [CommCoreModule] implement C++ ReportStore. · Explain WhyJul 31 2023, 3:03 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMe58543880d96: [CommCoreModule] implement C++ ReportStore.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CMakeLists.txt

2 lines

CommCoreModule.h

2 lines

CommCoreModule.cpp

117 lines

PersistentStorageUtilities/

DataStores/

ReportStore.h

29 lines

ReportStore.cpp

62 lines

ios/

Comm.xcodeproj/

project.pbxproj

6 lines

Diff 29287

View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ReportStore.h

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ReportStore.cpp

View Options

native/ios/Comm.xcodeproj/project.pbxproj

[CommCoreModule] implement C++ ReportStoreClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29287

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ReportStore.h

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ReportStore.cpp

native/ios/Comm.xcodeproj/project.pbxproj

[CommCoreModule] implement C++ ReportStore
ClosedPublic
Actions

Revision Contents
Changeset List