[CommCoreModule] remove unused includes
ClosedPublic
Actions

Authored by kamil on Jul 29 2023, 3:14 AM.

Details

Reviewers

michal
• jon
atul
tomek

Commits

rCOMM2e1a07a28af9: [CommCoreModule] remove unused includes

Summary

They are not needed anymore.

Depends on D8663

Test Plan

Build iOS and Android.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 29 2023, 3:14 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 29 2023, 3:14 AM

Harbormaster completed remote builds in B21335: Diff 29226.Jul 29 2023, 3:33 AM

kamil published this revision for review.Jul 31 2023, 1:31 AM

tomek accepted this revision.Jul 31 2023, 3:55 AM

This revision is now accepted and ready to land.Jul 31 2023, 3:55 AM

rebase

Harbormaster completed remote builds in B21367: Diff 29271.Jul 31 2023, 7:35 AM

Closed by commit rCOMM2e1a07a28af9: [CommCoreModule] remove unused includes (authored by kamil). · Explain WhyJul 31 2023, 8:03 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM2e1a07a28af9: [CommCoreModule] remove unused includes.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

4 lines

Diff 29286

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show All 29 Lines	import {
threadPermissions,		threadPermissions,
threadTypes,		threadTypes,
} from 'lib/types/thread-types.js';		} from 'lib/types/thread-types.js';
import { updateTypes } from 'lib/types/update-types.js';		import { updateTypes } from 'lib/types/update-types.js';
import { ServerError } from 'lib/utils/errors.js';		import { ServerError } from 'lib/utils/errors.js';
import { promiseAll } from 'lib/utils/promises.js';		import { promiseAll } from 'lib/utils/promises.js';
import { firstLine } from 'lib/utils/string-utils.js';		import { firstLine } from 'lib/utils/string-utils.js';

		import { reportLinkUsage } from './link-updaters.js';
import { updateRoles } from './role-updaters.js';		import { updateRoles } from './role-updaters.js';
import {		import {
changeRole,		changeRole,
recalculateThreadPermissions,		recalculateThreadPermissions,
commitMembershipChangeset,		commitMembershipChangeset,
} from './thread-permission-updaters.js';		} from './thread-permission-updaters.js';
import createMessages from '../creators/message-creator.js';		import createMessages from '../creators/message-creator.js';
import { createUpdates } from '../creators/update-creator.js';		import { createUpdates } from '../creators/update-creator.js';
import { dbQuery, SQL } from '../database/database.js';		import { dbQuery, SQL } from '../database/database.js';
import { fetchEntryInfos } from '../fetchers/entry-fetchers.js';		import { fetchEntryInfos } from '../fetchers/entry-fetchers.js';
		import { checkIfInviteLinkIsValid } from '../fetchers/link-fetchers.js';
import {		import {
fetchMessageInfos,		fetchMessageInfos,
fetchMessageInfoByID,		fetchMessageInfoByID,
} from '../fetchers/message-fetchers.js';		} from '../fetchers/message-fetchers.js';
import {		import {
fetchThreadInfos,		fetchThreadInfos,
fetchServerThreadInfos,		fetchServerThreadInfos,
determineThreadAncestry,		determineThreadAncestry,
} from '../fetchers/thread-fetchers.js';		} from '../fetchers/thread-fetchers.js';
import {		import {
checkThreadPermission,		checkThreadPermission,
viewerIsMember as fetchViewerIsMember,		viewerIsMember as fetchViewerIsMember,
checkThread,		checkThread,
validateCandidateMembers,		validateCandidateMembers,
} from '../fetchers/thread-permission-fetchers.js';		} from '../fetchers/thread-permission-fetchers.js';
import {		import {
verifyUserIDs,		verifyUserIDs,
verifyUserOrCookieIDs,		verifyUserOrCookieIDs,
} from '../fetchers/user-fetchers.js';		} from '../fetchers/user-fetchers.js';
		import { handleAsyncPromise } from '../responders/handlers.js';
import type { Viewer } from '../session/viewer.js';		import type { Viewer } from '../session/viewer.js';
import RelationshipChangeset from '../utils/relationship-changeset.js';		import RelationshipChangeset from '../utils/relationship-changeset.js';

async function updateRole(		async function updateRole(
viewer: Viewer,		viewer: Viewer,
request: RoleChangeRequest,		request: RoleChangeRequest,
): Promise<ChangeThreadSettingsResult> {		): Promise<ChangeThreadSettingsResult> {
if (!viewer.loggedIn) {		if (!viewer.loggedIn) {
▲ Show 20 Lines • Show All 729 Lines • ▼ Show 20 Lines
async function joinThread(		async function joinThread(
viewer: Viewer,		viewer: Viewer,
request: ServerThreadJoinRequest,		request: ServerThreadJoinRequest,
): Promise<ThreadJoinResult> {		): Promise<ThreadJoinResult> {
if (!viewer.loggedIn) {		if (!viewer.loggedIn) {
throw new ServerError('not_logged_in');		throw new ServerError('not_logged_in');
}		}

const [isMember, hasPermission] = await Promise.all([		const permissionCheck = request.inviteLinkSecret
fetchViewerIsMember(viewer, request.threadID),		? checkIfInviteLinkIsValid(request.inviteLinkSecret, request.threadID)
checkThreadPermission(		: checkThreadPermission(
viewer,		viewer,
request.threadID,		request.threadID,
threadPermissions.JOIN_THREAD,		threadPermissions.JOIN_THREAD,
),		);
		const [isMember, hasPermission] = await Promise.all([
		fetchViewerIsMember(viewer, request.threadID),
		permissionCheck,
]);		]);
if (!hasPermission) {		if (!hasPermission) {
throw new ServerError('invalid_parameters');		throw new ServerError('invalid_parameters');
}		}

// TODO: determine code version		// TODO: determine code version
const hasCodeVersionBelow87 = !hasMinCodeVersion(viewer.platformDetails, 87);		const hasCodeVersionBelow87 = !hasMinCodeVersion(viewer.platformDetails, 87);
const hasCodeVersionBelow62 = !hasMinCodeVersion(viewer.platformDetails, 62);		const hasCodeVersionBelow62 = !hasMinCodeVersion(viewer.platformDetails, 62);
Show All 29 Lines	): Promise<ThreadJoinResult> {
}		}

const changeset = await changeRole(request.threadID, [viewer.userID], null);		const changeset = await changeRole(request.threadID, [viewer.userID], null);

const membershipResult = await commitMembershipChangeset(viewer, changeset, {		const membershipResult = await commitMembershipChangeset(viewer, changeset, {
calendarQuery,		calendarQuery,
});		});

		if (request.inviteLinkSecret) {
		handleAsyncPromise(reportLinkUsage(request.inviteLinkSecret));
		}

const messageData = {		const messageData = {
type: messageTypes.JOIN_THREAD,		type: messageTypes.JOIN_THREAD,
threadID: request.threadID,		threadID: request.threadID,
creatorID: viewer.userID,		creatorID: viewer.userID,
time: Date.now(),		time: Date.now(),
};		};
const newMessages = await createMessages(viewer, [messageData]);		const newMessages = await createMessages(viewer, [messageData]);

▲ Show 20 Lines • Show All 150 Lines • Show Last 20 Lines

[CommCoreModule] remove unused includesClosedPublicActions