Page MenuHomePhabricator
Differential D8663

[CommCoreModule] implement C++ ReportStore
ClosedPublic
Actions

Authored by kamil on Jul 29 2023, 3:07 AM.
Tags
None
Referenced Files
F3390187: D8663.diff
Fri, Nov 29, 10:38 PM
Unknown Object (File)
Tue, Nov 5, 7:54 AM
Unknown Object (File)
Tue, Nov 5, 7:54 AM
Unknown Object (File)
Tue, Nov 5, 7:54 AM
Unknown Object (File)
Tue, Nov 5, 7:54 AM
Unknown Object (File)
Tue, Nov 5, 7:50 AM
Unknown Object (File)
Fri, Nov 1, 2:58 PM
Unknown Object (File)
Fri, Nov 1, 2:58 PM
View All 86 Files
Subscribers
ashoat

Details

Reviewers
michal
• jon
atul
tomek
Commits
rCOMMe58543880d96: [CommCoreModule] implement C++ ReportStore
Summary

Grouping logic in one class to make it cleaner and reuse some code.

Depends on D8662

Test Plan

Build iOS and Android and play with reports to make sure functionality still works.

Diff Detail

Repository
rCOMM Comm
Branch
core-module-refactor
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
2 lines
2 lines
115 lines
PersistentStorageUtilities/
DataStores/
30 lines
62 lines
ios/
Comm.xcodeproj/
6 lines

Diff 29225

View Options

native/cpp/CommonCpp/NativeModules/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ReportStore.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ReportStore.cpp

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...