Page MenuHomePhabricator
Differential D8344

[lib] Rename `setUserAvatar` to `baseSetUserAvatar` in `*EditUserAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 27 2023, 5:33 PM.
Tags
None
Referenced Files
F6279229: D8344.diff
Fri, Apr 25, 6:50 PM
Unknown Object (File)
Wed, Apr 23, 8:08 AM
Unknown Object (File)
Tue, Apr 22, 2:28 PM
Unknown Object (File)
Sun, Apr 20, 3:19 AM
Unknown Object (File)
Thu, Apr 17, 3:12 PM
Unknown Object (File)
Thu, Apr 17, 12:16 PM
Unknown Object (File)
Wed, Apr 16, 5:27 PM
Unknown Object (File)
Wed, Apr 16, 12:18 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
Commits
rCOMMdb1e95229675: [lib] Rename `setUserAvatar` to `baseSetUserAvatar` in `*EditUserAvatarProvider`
Summary

We want devs to to use the platform-specific setUserAvatar wrappers rather than interfacing with setUserAvatar directly... so renaming setUserAvatar to baseSetUserAvatar to make that more clear.

Also left a comment annotating the function, which at least in my editor shows a note on hover/when cursor is focused:

541bc9.png (318×1 px, 94 KB)

Depends on D8343

Test Plan

flow/eslint/searched codebase for "setUserAvatar".

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D8344 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 27 2023, 5:33 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 5:33 PM
atul published this revision for review.Jun 27 2023, 5:35 PM
atul edited the summary of this revision. (Show Details)Jun 27 2023, 5:38 PM
Harbormaster completed remote builds in B20562: Diff 28197.Jun 27 2023, 5:51 PM
atul added a child revision: D8345: Move registrationMode-related logic from `updateImageUserAvatar` to `nativeUpdateUserImageAvatar`.Jun 27 2023, 5:59 PM
rohan accepted this revision.Jun 28 2023, 10:08 AM
This revision is now accepted and ready to land.Jun 28 2023, 10:08 AM
atul edited the summary of this revision. (Show Details)Jun 28 2023, 12:38 PM
atul mentioned this in D8360: [lib] Rename `updateImageUserAvatar` to `baseUpdateImageUserAvatar` in `EditUserAvatarProvider`.Jun 28 2023, 12:40 PM
atul updated this revision to Diff 29206.Jul 28 2023, 1:44 PM

rebase and land

This revision was landed with ongoing or failed builds.Jul 28 2023, 1:47 PM
Closed by commit rCOMMdb1e95229675: [lib] Rename `setUserAvatar` to `baseSetUserAvatar` in `*EditUserAvatarProvider` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMdb1e95229675: [lib] Rename `setUserAvatar` to `baseSetUserAvatar` in `*EditUserAvatarProvider`.
Harbormaster completed remote builds in B21323: Diff 29206.Jul 28 2023, 2:30 PM
atul mentioned this in rCOMMfaab4fd75ad1: [lib] Rename `updateImageUserAvatar` to `baseUpdateImageUserAvatar` in….Jul 28 2023, 2:39 PM
atul mentioned this in D8759: [lib] Rename `setThreadAvatar` to `baseSetThreadAvatar` in `EditThreadAvatarProvider`.Aug 8 2023, 2:01 AM
atul mentioned this in rCOMMaae18d4b8285: [lib] Rename `setThreadAvatar` to `baseSetThreadAvatar` in….Aug 8 2023, 11:23 PM
bartek mentioned this in D9170: [web] Support avatar uploads to blob service.Nov 7 2023, 3:34 AM

Revision Contents
Changeset List

Diff 29206

View Options

lib/components/base-edit-user-avatar-provider.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

native/avatars/avatar-hooks.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

web/avatars/edit-user-avatar-menu.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

web/avatars/emoji-avatar-selection-modal.react.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents