Page MenuHomePhabricator
Differential D8687

[GH Actions] Remove "Install Yarn" step from Android workflows
ClosedPublic
Actions

Authored by atul on Jul 31 2023, 2:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 12:43 AM
Unknown Object (File)
Sun, Nov 10, 7:05 AM
Unknown Object (File)
Sat, Nov 9, 2:34 PM
Unknown Object (File)
Sat, Nov 9, 10:18 AM
Unknown Object (File)
Sat, Nov 9, 9:53 AM
Unknown Object (File)
Sat, Nov 9, 4:46 AM
Unknown Object (File)
Sun, Oct 20, 9:04 PM
Unknown Object (File)
Oct 9 2024, 11:07 AM
View All Files
Subscribers
michal

Details

Reviewers
ashoat
tomek
marcin
• jon
ginsu
Commits
rCOMMf675292aef91: [GH Actions] Remove "Install Yarn" step from Android workflows
Summary

This step is no longer necessary since Yarn 1.22.19 is included on Ubuntu 22.04 runners:

6b74c2.png (796×904 px, 88 KB)

(https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#package-management)

Test Plan

Removed step on fork and observed that subsequent yarn ci-cleaninstall step succeeded.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D8687 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jul 31 2023, 2:57 PM
atul edited the summary of this revision. (Show Details)Jul 31 2023, 2:57 PM
atul added a subscriber: michal.

I believe this can also be removed from windows_ci.yaml, but I left that alone (cc @michal).

atul published this revision for review.Jul 31 2023, 2:58 PM
atul mentioned this in D8688: [GH Actions] Remove JDK 11 step from Android workflows.Jul 31 2023, 3:01 PM
atul added a child revision: D8688: [GH Actions] Remove JDK 11 step from Android workflows.Jul 31 2023, 4:08 PM
Harbormaster completed remote builds in B21440: Diff 29368.Jul 31 2023, 11:54 PM
michal added a comment.Aug 1 2023, 2:29 AM

Can this be done for all runners? Both windows and macos seem to have Yarn 1.22.19

ashoat accepted this revision.Aug 1 2023, 5:36 AM

How about .github/workflows/windows_ci.yml? Can you update that one too before landing?

This revision is now accepted and ready to land.Aug 1 2023, 5:36 AM
atul added a comment.Aug 1 2023, 1:04 PM
In D8687#256541, @michal wrote:

Can this be done for all runners? Both windows and macos seem to have Yarn 1.22.19

In D8687#256602, @ashoat wrote:

How about .github/workflows/windows_ci.yml? Can you update that one too before landing?

Yeah mentioned in the comment that it could probably be done for the windows_ci workflow as well. Left it alone because I didn't want to risk breaking it and it'd take a while to test.

I'll update this diff to include the change and I guess revert if there are any issues.

atul updated this revision to Diff 29463.Aug 1 2023, 1:09 PM

remove install yarn step from all workflows

This revision was landed with ongoing or failed builds.Aug 1 2023, 1:11 PM
Closed by commit rCOMMf675292aef91: [GH Actions] Remove "Install Yarn" step from Android workflows (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMf675292aef91: [GH Actions] Remove "Install Yarn" step from Android workflows.
Harbormaster completed remote builds in B21479: Diff 29463.Aug 1 2023, 1:30 PM

Revision Contents
Changeset List

Diff 29463

View Options

.github/workflows/android_ci.yml

Loading...
View Options

.github/workflows/android_release.yml

Loading...
View Options

.github/workflows/eslint_flow_jest.yml

Loading...
View Options

.github/workflows/ios_ci.yml

Loading...
View Options

.github/workflows/ios_release.yml

Loading...
View Options

.github/workflows/jsi_codegen.yml

Loading...
View Options

.github/workflows/macos_ci.yml

Loading...
View Options

.github/workflows/remove_harbormaster_tags.yml

Loading...
View Options

.github/workflows/windows_ci.yml

Loading...